Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase build performance by skipping node_modules file lookups #1226

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/servicesHost.ts
Expand Up @@ -852,6 +852,14 @@ export function makeSolutionBuilderHost(
function getInputFileNameFromOutput(
outputFileName: string
): string | true | undefined {
// Unless we explicitly want to compile files in node_modules, exclude them from lookups
if (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @andrewbranch i am not familiar with monorepo projects out there that this will impact. I think somewhere we are missing the cache and that would be better solution in my opinion

!instance.loaderOptions.allowTsInNodeModules &&
outputFileName.indexOf('node_modules') !== -1
berickson1 marked this conversation as resolved.
Show resolved Hide resolved
) {
return undefined;
}

const resolvedFileName = filePathKeyMapper(outputFileName);
for (const configInfo of configFileInfo.values()) {
ensureInputOutputInfo(configInfo);
Expand Down