Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP for supporting project references further #1028

Closed
wants to merge 9 commits into from
Closed

WIP for supporting project references further #1028

wants to merge 9 commits into from

Conversation

sheetalkamat
Copy link
Contributor

Note there are console.log statements in the loader to debug this.
Also fyi this is not fully working

@sheetalkamat
Add test for package json existance
c9c2f41
@sheetalkamat
Show how output is different when module resolution resolves to .js/.…
12b586c 
…d.ts files
@sheetalkamat
Add input file of reference as dependency instead of .d.ts file
d0893bf
@sheetalkamat
Store tsbuildinfos written on solution builder host and hand it off a…
8873551 
…s asset
@sheetalkamat
.d.ts as assets only if written
daabbcb
@sheetalkamat
Make every project include just app and not other lib files
2b9723c
@sheetalkamat
Fix watching for solution watched files
7cd0938 
Add test that doesnt pass yet.
This is same as projectReferencesWatch so technically only change should be
in bundled emit to have out to be lib\out\index.js instead
@sheetalkamat
Dont depend on .d.ts output of the referenced project since we are de…
6069e1b 
…pending on .ts file for that

This fixes initial build to complete in single pass
@sheetalkamat
Some console logs to debug
94c2504
@teoxoy
Copy link

teoxoy commented Dec 1, 2019

Will this PR fix the issue brought up in #1003 (comment)?

Whilst this fixes the webpack not exiting with project references issue does this mean that watch mode doesn't work for project references with this PR? i.e. If I make a change to a dependent project with this change in place, does that mean that changes will not be picked up / builds retriggered?

I stumbled across this issue too.

@FrozenKiwi
Copy link

+1.

Is there anything we can do to help this along? I've started poking around the insides of ts-loader, but it's a lot to take in quickly. If you give some pointers, I'd be more than happy to try and contribute

@FrozenKiwi FrozenKiwi mentioned this pull request Jan 2, 2020
Closed
@johnnyreilly johnnyreilly mentioned this pull request Feb 18, 2020
Closed
@stale
Copy link

stale bot commented Mar 3, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 3, 2020
@stale
Copy link

stale bot commented Mar 10, 2020

Closing as stale. Please reopen if you'd like to work on this further.

@stale stale bot closed this Mar 10, 2020
@sheetalkamat sheetalkamat mentioned this pull request Apr 3, 2020
Merged
@MatthewCushing MatthewCushing mentioned this pull request Sep 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
wontfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sheetalkamat @teoxoy @FrozenKiwi