Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.6 was missing from Travis / AppVeyor build matrices. #1011

Merged
merged 10 commits into from Sep 20, 2019
Merged

3.6 was missing from Travis / AppVeyor build matrices. #1011

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
aa8e7ee
Update .travis.yml
johnnyreilly Sep 19, 2019
479d501
Update appveyor.yml
johnnyreilly Sep 19, 2019
3123a19
update comparison tests
johnnyreilly Sep 19, 2019
3e384d9
update to TS 3.6.3
johnnyreilly Sep 19, 2019
767dd78
make comparison test tolerant of different spaces
johnnyreilly Sep 19, 2019
43b9352
Fix when config includes referenced project sources and outputs as well
sheetalkamat Sep 19, 2019
686856b
Always run comparison test without transpile
sheetalkamat Sep 19, 2019
ab14f97
ignore case when matching file paths
sheetalkamat Sep 19, 2019
994bb22
Merge pull request #1013 from sheetalkamat/moreFixes
sheetalkamat Sep 19, 2019
ab890a3
Update CHANGELOG.md
johnnyreilly Sep 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions .travis.yml
View file
Open in desktop
Expand Up @@ -14,9 +14,10 @@ install:
- yarn lint
- yarn add $TYPESCRIPT
env:
- TYPESCRIPT=typescript@3.6.3
- TYPESCRIPT=typescript@next
- TYPESCRIPT=typescript@3.5.1
- TYPESCRIPT=typescript@3.4.4
- TYPESCRIPT=typescript@next
- TYPESCRIPT=typescript@3.3.3
- TYPESCRIPT=typescript@3.2.1
- TYPESCRIPT=typescript@3.1.1
Expand All @@ -27,4 +28,4 @@ env:
- TYPESCRIPT=typescript@2.6.1
- TYPESCRIPT=typescript@2.5.2
- TYPESCRIPT=typescript@2.4.1


3 changes: 2 additions & 1 deletion appveyor.yml
View file
Open in desktop
Expand Up @@ -3,9 +3,10 @@ environment:
FORCE_COLOR: 1
nodejs_version: "10"
matrix:
- TYPESCRIPT: typescript@3.6.3
- TYPESCRIPT: typescript@next
- TYPESCRIPT: typescript@3.5.1
- TYPESCRIPT: typescript@3.4.4
- TYPESCRIPT: typescript@next
- TYPESCRIPT: typescript@3.3.3
- TYPESCRIPT: typescript@3.2.1
- TYPESCRIPT: typescript@3.1.1
Expand Down
4 changes: 2 additions & 2 deletions test/comparison-tests/create-and-execute-test.js
View file
Open in desktop
Expand Up @@ -402,9 +402,9 @@ function getNormalisedFileContent(file, location) {
.replace(/Module build failed \(from \//gm, 'Module build failed (from ')
.replace(/Module Warning \(from \//gm, 'Module Warning (from ')
// We don't want a difference in the number of kilobytes to fail the build
.replace(/[\d]+([.][\d]*)? KiB/g, 'A-NUMBER-OF KiB')
.replace(/\s+[\d]+([.][\d]*)? KiB\s+/g, ' A-NUMBER-OF KiB ')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're getting some meaningless failures here related to whitespace in webpack output. These regex changes effectively normalize those differences. We want meaningful failures only 😄

// We also don't want a difference in the number of bytes to fail the build
.replace(/ \d+ bytes /g, ' A-NUMBER-OF bytes ')
.replace(/\s+\d+ bytes\s+/g, ' A-NUMBER-OF bytes ')
// Ignore whitespace between: Asset Size Chunks Chunk Names
.replace(/\s+Asset\s+Size\s+Chunks\s+Chunk Names/, ' Asset Size Chunks Chunk Names')
.replace(/ test\/comparison-tests\//,' /test/comparison-tests/')
Expand Down
2 changes: 1 addition & 1 deletion test/comparison-tests/nodeModulesMeaningfulErrorWhenImportingTs/expectedOutput-3.6/bundle.js
View file
Open in desktop
Expand Up @@ -105,7 +105,7 @@ eval("\nexports.__esModule = true;\nvar a = __webpack_require__(/*! a */ \"./nod
/*! no static exports found */
/***/ (function(module, exports) {

eval("throw new Error(\"Module build failed (from C:/source/ts-loader/index.js):/nError: TypeScript emitted no output for C://source//ts-loader//.test//nodeModulesMeaningfulErrorWhenImportingTs//node_modules//a//index.ts. By default, ts-loader will not compile .ts files in node_modules./nYou should not need to recompile .ts files there, but if you really want to, use the allowTsInNodeModules option./nSee: https://github.com/Microsoft/TypeScript/issues/12358/n at makeSourceMapAndFinish (C://source//ts-loader//dist//index.js:78:15)/n at successLoader (C://source//ts-loader//dist//index.js:68:9)/n at Object.loader (C://source//ts-loader//dist//index.js:22:12)\");\n\n//# sourceURL=webpack:///./node_modules/a/index.ts?");
eval("throw new Error(\"Module build failed (from C:/source/ts-loader/index.js):/nError: TypeScript emitted no output for C://source//ts-loader//.test//nodeModulesMeaningfulErrorWhenImportingTs//node_modules//a//index.ts. By default, ts-loader will not compile .ts files in node_modules./nYou should not need to recompile .ts files there, but if you really want to, use the allowTsInNodeModules option./nSee: https://github.com/Microsoft/TypeScript/issues/12358/n at makeSourceMapAndFinish (C://source//ts-loader//dist//index.js:80:15)/n at successLoader (C://source//ts-loader//dist//index.js:68:9)/n at Object.loader (C://source//ts-loader//dist//index.js:22:12)\");\n\n//# sourceURL=webpack:///./node_modules/a/index.ts?");

/***/ })

Expand Down
2 changes: 1 addition & 1 deletion .../comparison-tests/nodeModulesMeaningfulErrorWhenImportingTs/expectedOutput-3.6/output.txt
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ Module build failed (from /index.js):
Error: TypeScript emitted no output for node_modules\a\index.ts. By default, ts-loader will not compile .ts files in node_modules.
You should not need to recompile .ts files there, but if you really want to, use the allowTsInNodeModules option.
See: https://github.com/Microsoft/TypeScript/issues/12358
at makeSourceMapAndFinish (dist\index.js:78:15)
at makeSourceMapAndFinish (dist\index.js:80:15)
at successLoader (dist\index.js:68:9)
at Object.loader (dist\index.js:22:12)
@ ./app.ts 3:8-20
2 changes: 1 addition & 1 deletion ...son-tests/projectReferencesNotBuilt_SemanticErrorInReference/expectedOutput-3.6/bundle.js
View file
Open in desktop
Expand Up @@ -105,7 +105,7 @@ eval("\nexports.__esModule = true;\nvar lib_1 = __webpack_require__(/*! ./lib */
/*! no static exports found */
/***/ (function(module, exports) {

eval("throw new Error(\"Module build failed (from c:/github/ts-loader/index.js):/nError: TypeScript emitted no output for c://github//ts-loader//.test//projectReferencesNotBuilt_SemanticErrorInReference//lib//index.ts. The most common cause for this is having errors when building referenced projects./n at makeSourceMapAndFinish (c://github//ts-loader//dist//index.js:80:15)/n at successLoader (c://github//ts-loader//dist//index.js:68:9)/n at Object.loader (c://github//ts-loader//dist//index.js:22:12)\");\n\n//# sourceURL=webpack:///./lib/index.ts?");
eval("throw new Error(\"Module build failed (from C:/source/ts-loader/index.js):/nError: TypeScript emitted no output for C://source//ts-loader//.test//projectReferencesNotBuilt_SemanticErrorInReference//lib//index.ts. The most common cause for this is having errors when building referenced projects./n at makeSourceMapAndFinish (C://source//ts-loader//dist//index.js:80:15)/n at successLoader (C://source//ts-loader//dist//index.js:68:9)/n at Object.loader (C://source//ts-loader//dist//index.js:22:12)\");\n\n//# sourceURL=webpack:///./lib/index.ts?");

/***/ })

Expand Down
2 changes: 1 addition & 1 deletion ...rison-tests/projectReferencesNotBuilt_SyntaxErrorInReference/expectedOutput-3.6/bundle.js
View file
Open in desktop
Expand Up @@ -105,7 +105,7 @@ eval("\nexports.__esModule = true;\nvar lib_1 = __webpack_require__(/*! ./lib */
/*! no static exports found */
/***/ (function(module, exports) {

eval("throw new Error(\"Module build failed (from c:/github/ts-loader/index.js):/nError: TypeScript emitted no output for c://github//ts-loader//.test//projectReferencesNotBuilt_SyntaxErrorInReference//lib//index.ts. The most common cause for this is having errors when building referenced projects./n at makeSourceMapAndFinish (c://github//ts-loader//dist//index.js:80:15)/n at successLoader (c://github//ts-loader//dist//index.js:68:9)/n at Object.loader (c://github//ts-loader//dist//index.js:22:12)\");\n\n//# sourceURL=webpack:///./lib/index.ts?");
eval("throw new Error(\"Module build failed (from C:/source/ts-loader/index.js):/nError: TypeScript emitted no output for C://source//ts-loader//.test//projectReferencesNotBuilt_SyntaxErrorInReference//lib//index.ts. The most common cause for this is having errors when building referenced projects./n at makeSourceMapAndFinish (C://source//ts-loader//dist//index.js:80:15)/n at successLoader (C://source//ts-loader//dist//index.js:68:9)/n at Object.loader (C://source//ts-loader//dist//index.js:22:12)\");\n\n//# sourceURL=webpack:///./lib/index.ts?");

/***/ })

Expand Down
4 changes: 2 additions & 2 deletions ...ison-tests/projectReferencesWatchRefWithTwoFilesAlreadyBuilt/expectedOutput-3.6/bundle.js
View file
Open in desktop
Expand Up @@ -106,7 +106,7 @@ eval("\nexports.__esModule = true;\nvar lib_1 = __webpack_require__(/*! ./lib */
/***/ (function(module, exports, __webpack_require__) {

"use strict";
eval("\r\nexports.__esModule = true;\r\nexports.helper = {\r\n one: 1,\r\n two: 2,\r\n three: 3\r\n};\r\n\n\n//# sourceURL=webpack:///./lib/helper.ts?");
eval("\nexports.__esModule = true;\nexports.helper = {\n one: 1,\n two: 2,\n three: 3\n};\n\n\n//# sourceURL=webpack:///./lib/helper.ts?");

/***/ }),

Expand All @@ -118,7 +118,7 @@ eval("\r\nexports.__esModule = true;\r\nexports.helper = {\r\n one: 1,\r\n
/***/ (function(module, exports, __webpack_require__) {

"use strict";
eval("\r\nexports.__esModule = true;\r\nvar helper_1 = __webpack_require__(/*! ./helper */ \"./lib/helper.ts\");\r\nexports.lib = {\r\n one: helper_1.helper.one,\r\n two: helper_1.helper.two,\r\n three: helper_1.helper.three\r\n};\r\n\n\n//# sourceURL=webpack:///./lib/index.ts?");
eval("\nexports.__esModule = true;\nvar helper_1 = __webpack_require__(/*! ./helper */ \"./lib/helper.ts\");\nexports.lib = {\n one: helper_1.helper.one,\n two: helper_1.helper.two,\n three: helper_1.helper.three\n};\n\n\n//# sourceURL=webpack:///./lib/index.ts?");

/***/ })

Expand Down
12 changes: 6 additions & 6 deletions ...son-tests/projectReferencesWatchRefWithTwoFilesAlreadyBuilt/expectedOutput-3.6/output.txt
View file
Open in desktop
@@ -1,9 +1,9 @@
Asset Size Chunks Chunk Names
bundle.js 4.8 KiB main [emitted] main
../lib/index.d.ts 89 bytes [emitted]
../lib/helper.d.ts 92 bytes [emitted]
../lib/tsconfig.tsbuildinfo 71.4 KiB [emitted]
bundle.js 4.77 KiB main [emitted] main
../lib/index.d.ts 84 bytes [emitted]
../lib/helper.d.ts 87 bytes [emitted]
../lib/tsconfig.tsbuildinfo 72.7 KiB [emitted]
Entrypoint main = bundle.js
[./app.ts] 131 bytes {main} [built]
[./lib/helper.ts] 107 bytes {main} [built]
[./lib/index.ts] 197 bytes {main} [built]
[./lib/helper.ts] 100 bytes {main} [built]
[./lib/index.ts] 189 bytes {main} [built]
2 changes: 1 addition & 1 deletion ...sts/projectReferencesWatchRefWithTwoFilesAlreadyBuilt/expectedOutput-3.6/patch0/bundle.js
View file
Open in desktop
Expand Up @@ -106,7 +106,7 @@ eval("\nexports.__esModule = true;\nvar lib_1 = __webpack_require__(/*! ./lib */
/***/ (function(module, exports, __webpack_require__) {

"use strict";
eval("\r\nexports.__esModule = true;\r\nexports.helper = {\r\n one: 1,\r\n two: 2,\r\n three: 3\r\n};\r\n\n\n//# sourceURL=webpack:///./lib/helper.ts?");
eval("\nexports.__esModule = true;\nexports.helper = {\n one: 1,\n two: 2,\n three: 3\n};\n\n\n//# sourceURL=webpack:///./lib/helper.ts?");

/***/ }),

Expand Down
4 changes: 2 additions & 2 deletions ...ts/projectReferencesWatchRefWithTwoFilesAlreadyBuilt/expectedOutput-3.6/patch0/output.txt
View file
Open in desktop
@@ -1,8 +1,8 @@
Asset Size Chunks Chunk Names
bundle.js 4.82 KiB main [emitted] main
bundle.js 4.8 KiB main [emitted] main
../lib/index.d.ts 108 bytes [emitted]
../lib/tsconfig.tsbuildinfo 68.8 KiB [emitted]
Entrypoint main = bundle.js
[./app.ts] 131 bytes {main} [built]
[./lib/helper.ts] 107 bytes {main}
[./lib/helper.ts] 100 bytes {main}
[./lib/index.ts] 211 bytes {main} [built]
2 changes: 1 addition & 1 deletion test/comparison-tests/validateLoaderOptionNames/expectedOutput-3.6/bundle.js
View file
Open in desktop
Expand Up @@ -93,7 +93,7 @@
/*! no static exports found */
/***/ (function(module, exports) {

eval("throw new Error(\"Module build failed (from C:/source/ts-loader/index.js):/nError: ts-loader was supplied with an unexpected loader option: notRealOption/n/nPlease take a look at the options you are supplying; the following are valid options:/nsilent / logLevel / logInfoToStdOut / instance / compiler / context / configFile / transpileOnly / ignoreDiagnostics / errorFormatter / colors / compilerOptions / appendTsSuffixTo / appendTsxSuffixTo / onlyCompileBundledFiles / happyPackMode / getCustomTransformers / reportFiles / experimentalWatchApi / allowTsInNodeModules / experimentalFileCaching / projectReferences / resolveModuleName / resolveTypeReferenceDirective/n/n at validateLoaderOptions (C://source//ts-loader//dist//index.js:153:19)/n at getLoaderOptions (C://source//ts-loader//dist//index.js:110:5)/n at Object.loader (C://source//ts-loader//dist//index.js:16:21)\");\n\n//# sourceURL=webpack:///./app.ts?");
eval("throw new Error(\"Module build failed (from C:/source/ts-loader/index.js):/nError: ts-loader was supplied with an unexpected loader option: notRealOption/n/nPlease take a look at the options you are supplying; the following are valid options:/nsilent / logLevel / logInfoToStdOut / instance / compiler / context / configFile / transpileOnly / ignoreDiagnostics / errorFormatter / colors / compilerOptions / appendTsSuffixTo / appendTsxSuffixTo / onlyCompileBundledFiles / happyPackMode / getCustomTransformers / reportFiles / experimentalWatchApi / allowTsInNodeModules / experimentalFileCaching / projectReferences / resolveModuleName / resolveTypeReferenceDirective/n/n at validateLoaderOptions (C://source//ts-loader//dist//index.js:155:19)/n at getLoaderOptions (C://source//ts-loader//dist//index.js:112:5)/n at Object.loader (C://source//ts-loader//dist//index.js:16:21)\");\n\n//# sourceURL=webpack:///./app.ts?");

/***/ })

Expand Down
4 changes: 2 additions & 2 deletions test/comparison-tests/validateLoaderOptionNames/expectedOutput-3.6/output.txt
View file
Open in desktop
Expand Up @@ -10,6 +10,6 @@ Error: ts-loader was supplied with an unexpected loader option: notRealOption
Please take a look at the options you are supplying; the following are valid options:
silent / logLevel / logInfoToStdOut / instance / compiler / context / configFile / transpileOnly / ignoreDiagnostics / errorFormatter / colors / compilerOptions / appendTsSuffixTo / appendTsxSuffixTo / onlyCompileBundledFiles / happyPackMode / getCustomTransformers / reportFiles / experimentalWatchApi / allowTsInNodeModules / experimentalFileCaching / projectReferences / resolveModuleName / resolveTypeReferenceDirective

at validateLoaderOptions (dist\index.js:153:19)
at getLoaderOptions (dist\index.js:110:5)
at validateLoaderOptions (dist\index.js:155:19)
at getLoaderOptions (dist\index.js:112:5)
at Object.loader (dist\index.js:16:21)
6 changes: 3 additions & 3 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -5345,9 +5345,9 @@ typedarray@^0.0.6:
integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=

typescript@^3.6.2:
version "3.6.2"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.6.2.tgz#105b0f1934119dde543ac8eb71af3a91009efe54"
integrity sha512-lmQ4L+J6mnu3xweP8+rOrUwzmN+MRAj7TgtJtDaXE5PMyX2kCrklhg3rvOsOIfNeAWMQWO2F1GPc1kMD2vLAfw==
version "3.6.3"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.6.3.tgz#fea942fabb20f7e1ca7164ff626f1a9f3f70b4da"
integrity sha512-N7bceJL1CtRQ2RiG0AQME13ksR7DiuQh/QehubYcghzv20tnh+MQnQIuJddTmsbqYj+dztchykemz0zFzlvdQw==

uglify-es@^3.3.4:
version "3.3.9"
Expand Down