Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no errors reported if flagged with @ts-check #1008

Merged
merged 1 commit into from Sep 19, 2019
Merged

fix: no errors reported if flagged with @ts-check #1008

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/after-compile.ts
View file
Open in desktop
Expand Up @@ -183,7 +183,7 @@ function provideErrorsToWebpack(
} = instance;

const filePathRegex =
compilerOptions.checkJs === true
compilerOptions.allowJs === true
? constants.dtsTsTsxJsJsxRegex
: constants.dtsTsTsxRegex;

Expand Down
125 changes: 125 additions & 0 deletions test/comparison-tests/allowJs-ts-check/expectedOutput-3.6/bundle.js
View file
Open in desktop
@@ -0,0 +1,125 @@
/******/ (function(modules) { // webpackBootstrap
/******/ // The module cache
/******/ var installedModules = {};
/******/
/******/ // The require function
/******/ function __webpack_require__(moduleId) {
/******/
/******/ // Check if module is in cache
/******/ if(installedModules[moduleId]) {
/******/ return installedModules[moduleId].exports;
/******/ }
/******/ // Create a new module (and put it into the cache)
/******/ var module = installedModules[moduleId] = {
/******/ i: moduleId,
/******/ l: false,
/******/ exports: {}
/******/ };
/******/
/******/ // Execute the module function
/******/ modules[moduleId].call(module.exports, module, module.exports, __webpack_require__);
/******/
/******/ // Flag the module as loaded
/******/ module.l = true;
/******/
/******/ // Return the exports of the module
/******/ return module.exports;
/******/ }
/******/
/******/
/******/ // expose the modules object (__webpack_modules__)
/******/ __webpack_require__.m = modules;
/******/
/******/ // expose the module cache
/******/ __webpack_require__.c = installedModules;
/******/
/******/ // define getter function for harmony exports
/******/ __webpack_require__.d = function(exports, name, getter) {
/******/ if(!__webpack_require__.o(exports, name)) {
/******/ Object.defineProperty(exports, name, { enumerable: true, get: getter });
/******/ }
/******/ };
/******/
/******/ // define __esModule on exports
/******/ __webpack_require__.r = function(exports) {
/******/ if(typeof Symbol !== 'undefined' && Symbol.toStringTag) {
/******/ Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' });
/******/ }
/******/ Object.defineProperty(exports, '__esModule', { value: true });
/******/ };
/******/
/******/ // create a fake namespace object
/******/ // mode & 1: value is a module id, require it
/******/ // mode & 2: merge all properties of value into the ns
/******/ // mode & 4: return value when already ns object
/******/ // mode & 8|1: behave like require
/******/ __webpack_require__.t = function(value, mode) {
/******/ if(mode & 1) value = __webpack_require__(value);
/******/ if(mode & 8) return value;
/******/ if((mode & 4) && typeof value === 'object' && value && value.__esModule) return value;
/******/ var ns = Object.create(null);
/******/ __webpack_require__.r(ns);
/******/ Object.defineProperty(ns, 'default', { enumerable: true, value: value });
/******/ if(mode & 2 && typeof value != 'string') for(var key in value) __webpack_require__.d(ns, key, function(key) { return value[key]; }.bind(null, key));
/******/ return ns;
/******/ };
/******/
/******/ // getDefaultExport function for compatibility with non-harmony modules
/******/ __webpack_require__.n = function(module) {
/******/ var getter = module && module.__esModule ?
/******/ function getDefault() { return module['default']; } :
/******/ function getModuleExports() { return module; };
/******/ __webpack_require__.d(getter, 'a', getter);
/******/ return getter;
/******/ };
/******/
/******/ // Object.prototype.hasOwnProperty.call
/******/ __webpack_require__.o = function(object, property) { return Object.prototype.hasOwnProperty.call(object, property); };
/******/
/******/ // __webpack_public_path__
/******/ __webpack_require__.p = "";
/******/
/******/
/******/ // Load entry module and return exports
/******/ return __webpack_require__(__webpack_require__.s = "./src/index.js");
/******/ })
/************************************************************************/
/******/ ({

/***/ "./src/error1.js":
/*!***********************!*\
!*** ./src/error1.js ***!
\***********************/
/*! no static exports found */
/***/ (function(module, exports, __webpack_require__) {

"use strict";
eval("\nObject.defineProperty(exports, \"__esModule\", { value: true });\nvar Class1 = /** @class */ (function () {\n function Class1() {\n }\n Class1.prototype.foo = function () {\n this.bar;\n };\n return Class1;\n}());\nexports.Class1 = Class1;\n\n\n//# sourceURL=webpack:///./src/error1.js?");

/***/ }),

/***/ "./src/error2.js":
/*!***********************!*\
!*** ./src/error2.js ***!
\***********************/
/*! no static exports found */
/***/ (function(module, exports, __webpack_require__) {

"use strict";
eval("\nObject.defineProperty(exports, \"__esModule\", { value: true });\n// @ts-check\nvar Class2 = /** @class */ (function () {\n function Class2() {\n }\n Class2.prototype.foo = function () {\n this.bar;\n };\n return Class2;\n}());\nexports.Class2 = Class2;\n\n\n//# sourceURL=webpack:///./src/error2.js?");

/***/ }),

/***/ "./src/index.js":
/*!**********************!*\
!*** ./src/index.js ***!
\**********************/
/*! no static exports found */
/***/ (function(module, exports, __webpack_require__) {

"use strict";
eval("\nObject.defineProperty(exports, \"__esModule\", { value: true });\nvar error1_1 = __webpack_require__(/*! ./error1 */ \"./src/error1.js\");\nvar error2_1 = __webpack_require__(/*! ./error2 */ \"./src/error2.js\");\nnew error1_1.Class1().foo();\nnew error2_1.Class2().foo();\n\n\n//# sourceURL=webpack:///./src/index.js?");

/***/ })

/******/ });
6 changes: 6 additions & 0 deletions test/comparison-tests/allowJs-ts-check/expectedOutput-3.6/output.transpiled.txt
View file
Open in desktop
@@ -0,0 +1,6 @@
Asset Size Chunks Chunk Names
bundle.js 5.15 KiB main [emitted] main
Entrypoint main = bundle.js
[./src/error1.js] 265 bytes {main} [built]
[./src/error2.js] 278 bytes {main} [built]
[./src/index.js] 207 bytes {main} [built]
11 changes: 11 additions & 0 deletions test/comparison-tests/allowJs-ts-check/expectedOutput-3.6/output.txt
View file
Open in desktop
@@ -0,0 +1,11 @@
Asset Size Chunks Chunk Names
bundle.js 5.15 KiB main [emitted] main
Entrypoint main = bundle.js
[./src/error1.js] 265 bytes {main} [built]
[./src/error2.js] 278 bytes {main} [built] [1 error]
[./src/index.js] 207 bytes {main} [built]

ERROR in src\error2.js
./src/error2.js
[tsl] ERROR in src\error2.js(4,10)
 TS2339: Property 'bar' does not exist on type 'Class2'.
5 changes: 5 additions & 0 deletions test/comparison-tests/allowJs-ts-check/src/error1.js
View file
Open in desktop
@@ -0,0 +1,5 @@
export class Class1 {
foo() {
this.bar
}
}
6 changes: 6 additions & 0 deletions test/comparison-tests/allowJs-ts-check/src/error2.js
View file
Open in desktop
@@ -0,0 +1,6 @@
// @ts-check
export class Class2 {
foo() {
this.bar
}
}
5 changes: 5 additions & 0 deletions test/comparison-tests/allowJs-ts-check/src/index.js
View file
Open in desktop
@@ -0,0 +1,5 @@
import { Class1 } from './error1';
import { Class2 } from './error2';

new Class1().foo();
new Class2().foo();
12 changes: 12 additions & 0 deletions test/comparison-tests/allowJs-ts-check/tsconfig.json
View file
Open in desktop
@@ -0,0 +1,12 @@
{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"emitBOM": true,
"outDir": "node",
"allowJs": true
},
"include": [
"src"
]
}
20 changes: 20 additions & 0 deletions test/comparison-tests/allowJs-ts-check/webpack.config.js
View file
Open in desktop
@@ -0,0 +1,20 @@
module.exports = {
mode: 'development',
entry: './src/index.js',
output: {
filename: 'bundle.js'
},
resolve: {
extensions: ['.ts', '.js']
},
module: {
rules: [
{
test: /\.(js)$/,
loader: 'ts-loader'
}
]
}
}