Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin doesn't run for project references #187

Closed
MLoughry opened this issue Dec 7, 2018 · 9 comments
Closed

Plugin doesn't run for project references #187

MLoughry opened this issue Dec 7, 2018 · 9 comments

Comments

@MLoughry
Copy link

MLoughry commented Dec 7, 2018

Much like tslint and (to an extent) ts-loader, it seems this project doesn't yet fully support Typescript>=3.0.0 style project references. If I introduce an error into a dependent project, fork-ts-checker-webpack-plugin doesn't find the error.

@johnnyreilly
Copy link
Member

johnnyreilly commented Dec 8, 2018

If you'd like to have a crack at adding support you'd be most welcome! cc @andrewbranch - author of project reference support in ts-loader in case he has any thoughts 🌻♥️

See also: https://blog.johnnyreilly.com/2018/09/ts-loader-project-references-first-blood.html

@MLoughry
Copy link
Author

MLoughry commented Dec 9, 2018

I believe that, like TypeStrong/ts-loader#851, this ultimately requires the new Typescript APIs yet to be implemented and tracked by microsoft/TypeScript#28640.

I may look into making such a contribution once the APIs are available, to learn them for my own needs; but I don't think it's worthwhile to do so before then.

@noahm
Copy link

noahm commented Nov 22, 2019

The new API was added in microsoft/TypeScript#31432 and has been released in Typescript v3.6 so this should be unblocked now. Unfortunately, I don't know enough about how this plugin or the typescript API works to really tackle this myself yet.

@sikloidz
Copy link

There is any update on this feature? Currently my build it's ok with ts-loader but would be nice to be able to speed the compilation time by forking the type checking

@piotr-oles
Copy link
Collaborator

We are working on the major refactor of the plugin internals as a 5.0.0 release. The new implementation should support project references out of the box :)

@Ivaylo-Lafchiev
Copy link

Is there any updates on this? Would like to be able to use this & ts-loader with projectReferences.

@piotr-oles
Copy link
Collaborator

Currently, I'm focusing on refactoring and I hope I will release an alpha version in the next month. It's a huge task and I have limited time to work on it :)

@johnnyreilly
Copy link
Member

johnnyreilly commented Apr 10, 2020

Hey all,

The amazing @sheetalkamat is busy improving the project references support in ts-loader in TypeStrong/ts-loader#1076

Part of the discussion is around how transpileOnly should work alongside fork-ts-checker-webpack-plugin. Feel free to be part of the discussion 🌻🥰

@piotr-oles piotr-oles mentioned this issue Apr 18, 2020
26 tasks
@piotr-oles
Copy link
Collaborator

@MLoughry , @noahm , @sikloidz , @Ivaylo-Lafchiev
Please try fork-ts-checker-webpack-plugin@alpha - I've published a new version which supports project references 🚀
I will close this issue to clean-up the backlog :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants