Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: support typescript project references #155

Merged

Conversation

mfogel
Copy link
Contributor

@mfogel mfogel commented Oct 23, 2020

This PR adds support for typescript project references.

To do so, it upgrades the following dependencies:

This PR includes a new test with a basic typescript monorepo configured with project references.

It's kinda a bummer the eslint upgrade is bundled into this PR. The only way I see around that would be to upgrade eslint & associated tools first as a separate step, and then address this PR/feature request.

Let me know if you'd like to see any fixes/changes or anything else I can do to help merge this in. Thanks a bunch for serverless-bundle, super helpful! Cheers.

@jayair
Copy link
Member

jayair commented Nov 13, 2020

Thanks for putting this together!

So from what I can see the main changes are to the forkTsCheckerWebpackOptions?

The rest of this change is just the ESLint major upgrade correct?

It sounds like we would need to do a major release for this change.

@jayair
Copy link
Member

jayair commented Nov 14, 2020

So we ended upgrading ESLint in this release.

https://github.com/AnomalyInnovations/serverless-bundle/releases/tag/v4.0.0

Might make it easier to now support this feature. Can you fix the conflicts and I'll have a look?

@mfogel
Copy link
Contributor Author

mfogel commented Nov 14, 2020

Ah, great. That should simplify this PR a fair amount. I'll plan to update/rebase this PR on the latest on master over the weekend. Cheers

@mfogel mfogel force-pushed the feat/typescript-project-references branch from 6f855e6 to 57eff58 Compare November 14, 2020 15:09
@mfogel
Copy link
Contributor Author

mfogel commented Nov 14, 2020

@jayair PR has been updated, should merge cleanly now

@jayair
Copy link
Member

jayair commented Nov 22, 2020

Looks good!

@jayair jayair merged commit 37451e3 into AnomalyInnovations:master Nov 22, 2020
@jayair
Copy link
Member

jayair commented Nov 22, 2020

Pushed a new release https://github.com/AnomalyInnovations/serverless-bundle/releases/tag/v4.1.0

@mfogel mfogel deleted the feat/typescript-project-references branch November 23, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants