Skip to content

Commit

Permalink
Clarify message "No typescript errors found."
Browse files Browse the repository at this point in the history
When this message appears in context of webpack-dev-server,
it could be unclear what kind of errors (webpack build vs. typescript).
Sometimes there is a prior "Error checking in progress" message,
but not always, and may be far above the "No errors found."
  • Loading branch information
cben authored and piotr-oles committed May 15, 2024
1 parent 0fab463 commit 683a239
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/hooks/tap-done-to-async-get-issues.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function tapDoneToAsyncGetIssues(
// print stats of the compilation
config.logger.log(statsFormatter(issues, stats));
} else {
config.logger.log(chalk.green('No errors found.'));
config.logger.log(chalk.green('No typescript errors found.'));
}

// report issues to webpack-dev-server, if it's listening
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/driver/webpack-dev-server-driver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ function createWebpackDevServerDriver(
process.stdout.on('data', (data) => {
const content = stripAnsi(data.toString());

if (async && content.includes('No errors found.')) {
if (async && content.includes('No typescript errors found.')) {
noErrorsListener.resolve();
}

Expand Down

0 comments on commit 683a239

Please sign in to comment.