use static where possible

reduces stack alloc
Twinki14 · Dec 30, 2023 · 3b31c78 · 3b31c78
1 parent b1395fa
commit 3b31c78
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/src/Serilog/Capturing/DepthLimiter.cs b/src/Serilog/Capturing/DepthLimiter.cs
@@ -37,7 +37,7 @@ public DepthLimiter(int maximumDepth, PropertyValueConverter propertyValueConver
                 _propertyValueConverter = propertyValueConverter;
             }
 
-            public void SetCurrentDepth(int depth)
+            public static void SetCurrentDepth(int depth)
             {
                 _currentDepth = depth;
             }

diff --git a/src/Serilog/Capturing/PropertyValueConverter.cs b/src/Serilog/Capturing/PropertyValueConverter.cs
@@ -134,7 +134,7 @@ LogEventPropertyValue CreatePropertyValue(object value, Destructuring destructur
             }
 
             var valueType = value.GetType();
-            _depthLimiter.SetCurrentDepth(depth);
+            DepthLimiter.SetCurrentDepth(depth);
 
             if (destructuring == Destructuring.Destructure)
             {
@@ -309,7 +309,7 @@ string TruncateIfNecessary(string text)
             return text;
         }
 
-        bool TryGetDictionary(object value, Type valueType, out IDictionary dictionary)
+        static bool TryGetDictionary(object value, Type valueType, out IDictionary dictionary)
         {
             if (valueType.IsConstructedGenericType &&
                 valueType.GetGenericTypeDefinition() == typeof(Dictionary<,>) &&
@@ -323,7 +323,7 @@ bool TryGetDictionary(object value, Type valueType, out IDictionary dictionary)
             return false;
         }
 
-        bool IsValidDictionaryKeyType(Type valueType)
+        static bool IsValidDictionaryKeyType(Type valueType)
         {
             return BuiltInScalarTypes.Contains(valueType) ||
                    valueType.GetTypeInfo().IsEnum;

diff --git a/test/Serilog.Tests/LoggerConfigurationTests.cs b/test/Serilog.Tests/LoggerConfigurationTests.cs
@@ -427,7 +427,7 @@ public void MaximumCollectionCountNotEffectiveForDictionaryWithAsManyKeysAsLimit
             Assert.Contains("2", limitedCollection);
         }
 
-        private string LogAndGetAsString(object x, Func<LoggerConfiguration, LoggerConfiguration> conf, string destructuringSymbol = "")
+        private static string LogAndGetAsString(object x, Func<LoggerConfiguration, LoggerConfiguration> conf, string destructuringSymbol = "")
         {
             LogEvent evt = null;
             var logConf = new LoggerConfiguration()

diff --git a/test/Serilog.Tests/MethodOverloadConventionTests.cs b/test/Serilog.Tests/MethodOverloadConventionTests.cs
@@ -504,7 +504,7 @@ void ForContextMethod4(MethodInfo method)
         }
 
         // ReSharper disable once ParameterOnlyUsedForPreconditionCheck.Local
-        void TestForContextResult(MethodInfo method, ILogger logger, object normalResult)
+        static void TestForContextResult(MethodInfo method, ILogger logger, object normalResult)
         {
             Assert.NotNull(normalResult);
             Assert.True(normalResult is ILogger);