Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open editor when clicking on notification [2] #63

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

Open editor when clicking on notification [2] #63

wants to merge 10 commits into from

Commits on Dec 7, 2020

  1. ci(lint): temp disabled rules for next commits

    @Gvozd
    Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8b046a0 View commit details
    Browse the repository at this point in the history

  2. Add error/warning location to compiled message

    @alexanderchr @Gvozd
    alexanderchr authored and Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    64fae22 View commit details
    Browse the repository at this point in the history

  3. Add onclick listener on notifier that runs editor

    @alexanderchr @Gvozd
    alexanderchr authored and Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    c1a0a5b View commit details
    Browse the repository at this point in the history

  4. Add editor section in readme

    @alexanderchr @Gvozd
    alexanderchr authored and Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    99cbac1 View commit details
    Browse the repository at this point in the history

  5. test(snapshot): temp skip new node-notifier options to find other dif… 

    …ferences

no differences in existing tests, excellent work😃
    @Gvozd
    Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    a2b9f2c View commit details
    Browse the repository at this point in the history

  6. test(snapshot): re-generate all snapshots with new feature 

    TODO: check all snapshots with `"file": undefined`
    @Gvozd
    Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    8fdc1c0 View commit details
    Browse the repository at this point in the history

  7. [WIP] build(notifier): temp fix click event on SnoreToast 

    see mikaelbr/node-notifier#347
wait for node-notifier release
    @Gvozd
    Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    76ab96a View commit details
    Browse the repository at this point in the history

  8. [WIP] fix: work with location in callback of notify 

    because the node-notifier no longer sends additional options in the click event
    @Gvozd
    Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    6537b3a View commit details
    Browse the repository at this point in the history

  9. fix: support whitespace symbol in command 

    this need e.g. windows, in case editor installed in `C:\Program Files\`
    @Gvozd
    Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    593a333 View commit details
    Browse the repository at this point in the history

  10. [WIP] test on WebStorm

    @Gvozd
    Gvozd committed Dec 7, 2020
    Configuration menu
    Copy the full SHA
    2d63766 View commit details
    Browse the repository at this point in the history