Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-notifier to v6 #56

Merged
merged 1 commit into from Nov 15, 2020
Merged

Update node-notifier to v6 #56

merged 1 commit into from Nov 15, 2020

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2019

Toast notifications are currently broken on Windows. node-notifier 6.0.0 uses the latest version of SnoreToast.exe which fixes the issue:
https://github.com/mikaelbr/node-notifier/blob/master/CHANGELOG.md

@Gvozd
Copy link
Collaborator

Gvozd commented Nov 19, 2019

BUMP
Without this update notifier not worked at WSL

As temp workaround i use yarn && resolutions field in package.json

  "resolutions": {
    "node-notifier": "6.0.0"
  }

inoyakaigor pushed a commit to inoyakaigor/webpack-notifier-2 that referenced this pull request Dec 10, 2019
inoyakaigor pushed a commit to inoyakaigor/webpack-notifier-2 that referenced this pull request Dec 10, 2019
@Gvozd
Copy link
Collaborator

Gvozd commented Oct 31, 2020

@Turbo87, any news about this?

@Turbo87
Copy link
Owner

Turbo87 commented Oct 31, 2020

I'm not using this project anymore myself so I don't have much time to maintain it at the moment. If someone wants to take over maintenance let me know.

@Gvozd
Copy link
Collaborator

Gvozd commented Nov 1, 2020

@inoyakaigor, your fork is the most developed
Do you want to take over maintenance for this package?

@Gvozd
Copy link
Collaborator

Gvozd commented Nov 4, 2020

@Turbo87 OK. I am ready to maintain this project

I have previously maintained third-party projects:
https://github.com/codemix/babel-plugin-macros
https://github.com/codemix/babel-plugin-closure-elimination

Can you give me permisions to the repository and publish packages?
Or do you want to see my PR for existing issues first?

@Gvozd Gvozd mentioned this pull request Nov 4, 2020
@Turbo87
Copy link
Owner

Turbo87 commented Nov 15, 2020

Can you give me permisions to the repository and publish packages?

done, thanks for taking over :)

@inoyakaigor
Copy link
Contributor

@Gvozd oh, late to the party

@Gvozd Gvozd merged commit a3624ac into Turbo87:master Nov 15, 2020
@Gvozd
Copy link
Collaborator

Gvozd commented Nov 15, 2020

@Turbo87 Thanks)

@inoyakaigor nothing wrong)
Later I will look at the changes in your repository, and will probably apply them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants