Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-inner-literal rule #84

Merged
merged 2 commits into from Oct 25, 2019
Merged

Add no-inner-literal rule #84

merged 2 commits into from Oct 25, 2019

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Oct 25, 2019 •
edited by Turbo87

Resolves #17

Turbo87
Turbo87 reviewed Oct 25, 2019
View reviewed changes
lib/rules/no-inner-literal.js Outdated Show resolved Hide resolved
tests/lib/rules/no-inner-literal.js Outdated Show resolved Hide resolved
@brettz9 brettz9 force-pushed the no-inner-literal branch 2 times, most recently from 55b326a to 904b8c3 Compare October 25, 2019 10:24
@Turbo87 Turbo87 changed the title - Add inner literal rule; fixes #17 Add no-inner-literal rule Oct 25, 2019
@Turbo87
Copy link
Owner

Turbo87 commented Oct 25, 2019

hmm, looks like some of the older ESLint versions are not happy about the ecmaVersion for the BigInt test

@brettz9
Copy link
Contributor Author

brettz9 commented Oct 25, 2019

I could do a try-catch with an eval('13n') to dynamically determine whether the environment supports...

@Turbo87
Copy link
Owner

Turbo87 commented Oct 25, 2019

we could probably check require('eslint/package.json').version 🤔

@brettz9 brettz9 force-pushed the no-inner-literal branch 2 times, most recently from e5e2f10 to 1b7a16f Compare October 25, 2019 13:33
@brettz9
Copy link
Contributor Author

brettz9 commented Oct 25, 2019

Yeah, better idea... Done...

@brettz9
Copy link
Contributor Author

brettz9 commented Oct 25, 2019

And passing...

@brettz9 brettz9 force-pushed the no-inner-literal branch 3 times, most recently from 71c985e to e129aaa Compare October 25, 2019 13:49
@Turbo87 Turbo87 merged commit 9b4ab55 into Turbo87:master Oct 25, 2019
@brettz9 brettz9 deleted the no-inner-literal branch October 25, 2019 14:02
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Turbo87 Turbo87 Turbo87 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent expect(true).to.be.false
2 participants
@brettz9 @Turbo87