fix error when used with rollup@1.0.0+ #27
Conversation
|
@TrySound @transitive-bullshit can we please merge this PR? |
|
@TrySound i hope you are not ignoring development to this repo because no one is contributing to your beerpay 😮 |
| @@ -1,5 +1,9 @@ | |||
| dist: xenial | |||
There was a problem hiding this comment.
testing on latest LTS ubuntu distro 16.x instead of default 14.x
won't really matter with our use case
but i thought it is a nice thing to have
| - "8" | ||
| - "6" | ||
| cache: yarn | ||
| before_install: | ||
| yarn config set ignore-engines true |
There was a problem hiding this comment.
yarn throws error when installing a transitive package where engine is marked as requiring node >=8
npm works fine. This command relaxes that check like npm.
https://stackoverflow.com/questions/45088031/how-to-ignore-incompatible-engine-node-error-on-installing-npm-dependencies-wi
There was a problem hiding this comment.
| language: node_js | ||
| node_js: | ||
| - "9" | ||
| - "10" |
There was a problem hiding this comment.
I prefer to add also "node" to check in the latest node version
There was a problem hiding this comment.
yes, i will add that as well
| }) | ||
| ) | ||
| .then( | ||
| (result): Output => { |
There was a problem hiding this comment.
Did prettier formatted this way?
There was a problem hiding this comment.
yes, via precommit hook. something off?
| .map(node => node.end - node.start) | ||
| .reduce((acc, size) => acc + size, 0); | ||
| .then(({ output }) => | ||
| minify(output.find(chunkOrAsset => chunkOrAsset.code).code, { |
There was a problem hiding this comment.
Is there any output without code?
There was a problem hiding this comment.
yes, there can be assets or code
rollup/rollup#2293
|
any other changes needed? |
|
Thanks! |
fixes #26