Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new custom email validator #90

Merged
merged 3 commits into from
Dec 16, 2022
Merged

Added new custom email validator #90

merged 3 commits into from
Dec 16, 2022

Commits on Dec 16, 2022

  1. Added new custom email validator 

    refs https://github.com/TryGhost/Team/issues/2235

The `validator` package used in our codebase is stuck on an old version due to some constraints. The `isEmail` check on the old version is unable to detect some invalid email addresses causing them to sneak through and get stored.
This change adds a custom `isEmail` validator picked from the latest version of `validator` package, and allows us to gradually update the email checks to use the new version so we can prevent invalid email addresses to enter the system.
    @rishabhgrg
    rishabhgrg committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    a59a404 View commit details
    Browse the repository at this point in the history

  2. fixup! Added new custom email validator

    @rishabhgrg
    rishabhgrg committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    f56a650 View commit details
    Browse the repository at this point in the history

  3. fixup! Added new custom email validator

    @rishabhgrg
    rishabhgrg committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    220a3c6 View commit details
    Browse the repository at this point in the history