New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[admin-api] Add overridable `makeRequest` function #50

Merged

kevinansfield merged 2 commits into TryGhost:master from kevinansfield:admin-api/makeRequest-override

Feb 14, 2019

Contributor

kevinansfield commented Feb 13, 2019 •

edited

refs #48

refactors internals to split url generation, authentication, and request handling into separate functions
allow makeRequest to be passed in as an option to override the default axios based function

kevinansfield force-pushed the admin-api/makeRequest-override branch from 868934a to 3bd4e87 Compare

February 14, 2019 09:58

kevinansfield added 2 commits

February 14, 2019 10:05


          refactor internal methods to extract makeRequest

63b0767


          allow makeRequest to be overridden

kevinansfield force-pushed the admin-api/makeRequest-override branch from 3bd4e87 to 2510380 Compare

February 14, 2019 10:06

kevinansfield merged commit 79927ec into TryGhost:master

kevinansfield deleted the admin-api/makeRequest-override branch

February 14, 2019 10:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment