Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix body length limit when uploading themes #422

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

AWaselnuk
Copy link
Contributor

My theme deploys began failing last week with the axios error described in this issue: #195

It turns out that axios now requires maxBodyLength to be the property we use in config to remove the upload limit.

I haven't been able to pin down exactly why or when this config changed, though it might be connected to this recent pull request introducing the separate maxBodyLength option axios/axios#2781


Got some code for us? Awesome 馃帄!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test and yarn lint)

More info can be found by clicking the "guidelines for contributing" link above.

@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2022

Codecov Report

Merging #422 (12a06d5) into main (1f90c51) will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #422      +/-   ##
==========================================
+ Coverage   87.60%   87.68%   +0.08%     
==========================================
  Files          54       54              
  Lines        2485     2485              
  Branches      440      440              
==========================================
+ Hits         2177     2179       +2     
+ Misses        305      303       -2     
  Partials        3        3              
Impacted Files Coverage 螖
index.js 91.38% <0.00%> (+0.39%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1f90c51...12a06d5. Read the comment docs.

@naz naz merged commit ded5a1f into TryGhost:main Apr 18, 2022
@naz
Copy link
Member

naz commented Apr 18, 2022

Thanks for taking time to contribute @AWaselnuk!

@kaveet
Copy link

kaveet commented May 16, 2022

Hello!

I'm surfacing this issue, which appears to be somewhat related to this thread: TryGhost/action-deploy-theme#68

@AWaselnuk, did you find that the change to Infinity helped your use case? I've found that Infinity isn't respected--you have to pass some value. In my case, changing this option to 500MB did the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants