Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose primitives in GhostAdminAPI #48

Closed
1 of 5 tasks
kevinansfield opened this issue Feb 6, 2019 · 3 comments
Closed
1 of 5 tasks

Expose primitives in GhostAdminAPI #48

kevinansfield opened this issue Feb 6, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@kevinansfield
Copy link
Contributor

kevinansfield commented Feb 6, 2019

In our @tryghost/admin-api package we only expose direct methods for calling specific endpoints. The auth, url building, data processing, etc aspects all exist but are hidden as internal implementation details.

We'd like to expose as many primitives as possible for SDK users to build their own implementations around in case the provided all-in-one wrapper is insufficient.

The first real-world use-case that's been identified is when using the package inside of Zapier. Zapier provides its own request library which comes with benefits like logging of all requests for easier external debugging.

TODO:

  • expose internals as separately usable APIs
    • authentication
    • url generation
    • data processing
  • allow the networking side of the all-in-one wrapper be overridden/injected
@kevinansfield kevinansfield added the enhancement New feature or request label Feb 6, 2019
@kevinansfield kevinansfield self-assigned this Feb 6, 2019
@kevinansfield
Copy link
Contributor Author

I've run into this bug in axios when using GhostAdminAPI inside our Zapier app axios/axios#1625. Unfortunately the fix has only been released in a beta that is currently failing tests so it's not something we can upgrade to fix but it does add some more urgency to allowing the request method to over overridden/injected.

@kirrg001
Copy link
Contributor

@kevinansfield What is the state of this issue?

@ErisDS
Copy link
Member

ErisDS commented Aug 30, 2022

Going to close this as we have some improvements planned, but so far this hasn't really been an issue.

@ErisDS ErisDS closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants