Only mount vmsnap checkpoints #772
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudAPI offers a method of managing zfs snapshots. These are prefixed with vmsnap, and are mounted on zone boot via lofs into /checkpoints However currently, the zone boot code mounts all snapshots via lofs into /checkpoints. This presents issues for snapshots created/deleted in the global zone, that we perhaps don't want automounted or exposed to customers. For example in our use-case, backup snapshots. The main issue here is with snapshot deletion. By simply mounting vmsnap snapshots only, we avoid this issue whilst retaining compatibility with Triton's CloudAPI snapshot functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CloudAPI offers a method of managing zfs snapshots. These are prefixed with vmsnap, and are mounted on zone boot via lofs into /checkpoints
However currently, the zone boot code mounts all snapshots via lofs into /checkpoints. This presents issues for snapshots created/deleted in the global zone, that we perhaps don't want automounted or exposed to customers. For example in our use-case, backup snapshots. The main issue here is with snapshot deletion - this leaves broken lofs mounts in the client zone.
By simply mounting vmsnap snapshots only, we avoid this issue whilst retaining compatibility with Triton's CloudAPI snapshot functionality.