OS-8498 Want 'piadm destroy' as an alias for 'piadm remove' #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmcd
reviewed
Nov 9, 2023
| @@ -1544,7 +1545,7 @@ case $cmd in | |||
| list "$@" | |||
| ;; | |||
|
|
|||
| remove ) | |||
| destroy | remove ) | |||
| privcheck remove | |||
| standalone_only remove | |||
There was a problem hiding this comment.
Change standalone_only remove to standalone_only "$cmd" please.
| @@ -12,7 +12,7 @@ piadm(8) -- Manage SmartOS Platform Images | |||
| piadm bootable -e [ -i <source> ] <ZFS-pool-name> | |||
| piadm install <source> [ZFS-pool-name] | |||
| piadm list [ZFS-pool-name] | |||
| piadm remove <PI-stamp> [ZFS-pool-name] | |||
There was a problem hiding this comment.
Because "destroy" realphabetizes things, you'll have to re-sort this list.
| @@ -256,12 +256,16 @@ piadm(8) -- Manage SmartOS Platform Images | |||
| Lists the available platform images (and boot images) on bootable | |||
| pools. | |||
|
|
|||
There was a problem hiding this comment.
Same with this section needing to move.
| @@ -54,7 +55,7 @@ usage() { | |||
| eecho " piadm bootable [-d] [-e [-i <source>]] [-r] [ZFS-pool-name]" | |||
| eecho " piadm install <source> [ZFS-pool-name]" | |||
| eecho " piadm list <-H> [ZFS-pool-name]" | |||
| eecho " piadm remove <PI-stamp> [ZFS-pool-name]" | |||
There was a problem hiding this comment.
And same with the help message.
danmcd
changed the title
|
We'd filed a bug because of this PR. I'm trying to link them together now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For those used to beadm(8), adds an alias
destroyforremove.I've tested it by deleting a PI (verified using
piadm listbefore and after deletion.