Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-7120 ipmi_lan_get_config() doesn't really get IPv6 #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joyent-automation
Copy link

OS-7120 ipmi_lan_get_config() doesn't really get IPv6

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/4671/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@danmcd commented at 2018-08-20T18:22:53

Patch Set 1:

How did you test this? Can I see some test outputs?

@danmcd commented at 2018-08-20T18:26:52

Patch Set 1:

(1 comment)

Yeah, I'd like to see some configurations and output from what you've got here. Some of the names & concepts still aren't quite jiving with what I read in the spec, but I may have misread the spec too.

Patch Set 1 code comments
usr/src/lib/libipmi/common/libipmi.h#321 @danmcd

Hmmm... as I read the spec, I thought these were static addresses that were useable as default route destinations. I.e. 0::0/0 ==> . The prefix length part of ipmi_ipv6_addr_t is useless here, and possibly misleading. IF the spec allows non-default static routes / ==> , you need two IPv6 addrs (, ) and a prefix-length, applicable to .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants