Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS-6459 logadm should use absolute paths for filenames Reviewed by: Michael Zeller <mike.zeller@joyent.com> #213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joyent-automation
Copy link

OS-6459 logadm should use absolute paths for filenames
Reviewed by: Michael Zeller mike.zeller@joyent.com

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/2977/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@bahamas10 commented at 2017-11-21T08:24:49

Patch Set 1:

New commits:
commit be6deff4b48bc7385011ab72e9fda6358f4c8990
initial commit

@bahamas10 commented at 2017-11-21T17:29:01

Patch Set 2:

New commits:
commit 4c90b9405db1af4ed5023713a2e3d4b16d8691a9
comment style and donenames use fname

@bahamas10 commented at 2017-11-21T17:30:12

Patch Set 3:

New commits:
commit f6bd503af86dc7ffe9890a58a3f15e0ed00043b0
fix argument mismatch

@papertigers commented at 2017-11-22T16:57:07

Patch Set 3: Code-Review+1

@bahamas10 commented at 2017-11-22T17:34:29

Uploaded patch set 4: Commit message was updated.

@bahamas10 commented at 2017-11-22T17:35:02

Uploaded patch set 5: Patch Set 4 was rebased.

@bahamas10 commented at 2017-11-22T17:35:09

Patch Set 5:

New commits:
commit e46c2772b4717d3c14ba297af50cd4f7c06fae0e
fix argument mismatch

commit c30900d8f35644091512fc72b937f6cf49a23887  
comment style and donenames use fname

commit 02d3a4da3bf0997e4577cc595bedf06042344811  
initial commit
@bahamas10 commented at 2018-01-22T17:01:19

Patch Set 6:

New commits:
commit f88fa91988f82c50bbc21758a0e90e87a3812709
copyright

commit 0ae237c05cd20ab349ddcb505614e186d236ab32  
fix argument mismatch

commit dcbb3784332342acccbcb68fef73d48d9aae4f77  
comment style and donenames use fname

commit 641c5233a8811c68283fe349143c22ac6713a87a  
initial commit
@mgerdts commented at 2018-01-22T17:26:53

Patch Set 6:

(1 comment)

Patch Set 6 code comments
usr/src/cmd/logadm/main.c#595 @mgerdts

It would seem less fragile to call realpath() after lstat().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants