Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vendor.css creation #84

Closed
wants to merge 1 commit into from
Closed

Enable vendor.css creation #84

wants to merge 1 commit into from

Conversation

AbrarJahin
Copy link
Contributor

No description provided.

@AbrarJahin
Copy link
Contributor Author

If this code is uncommented like this, vendor.css will be generated

@AbrarJahin
Copy link
Contributor Author

Please check and let me know if it is working or not.

I am finding it working @MarkPieszak

@MarkPieszak
Copy link
Member

When you run npm run postinstall (which runs the webpack vendor bundling) you don't get any errors?

I kept seeing this before, and tried again, same thing. Seems like some underlying fontawesome issue with the latest webpack, not sure yet.

    ERROR in ./~/font-awesome/fonts/fontawesome-webfont.eot
    Module parse failed: C:\Users\mark.pieszak\Documents\GitHub\aspnetcore-angular2-universal\node_modules\font-awesome\fonts\fontawesome-webfont.eot Unexpected character '�' (1:1)
    You may need an appropriate loader to handle this file type.
    (Source code omitted for this binary file)
     @ ./~/css-loader!./~/font-awesome/css/font-awesome.css 6:378-421
     @ ./~/font-awesome/css/font-awesome.css
     @ dll vendor

    ERROR in ./~/font-awesome/fonts/fontawesome-webfont.woff2?v=4.7.0
    Module parse failed: C:\Users\mark.pieszak\Documents\GitHub\aspnetcore-angular2-universal\node_modules\font-awesome\fonts\fontawesome-webfont.woff2?v=4.7.0 Unexpected character ' ' (1:4)

    You may need an appropriate loader to handle this file type.
    (Source code omitted for this binary file)
     @ ./~/css-loader!./~/font-awesome/css/font-awesome.css 6:479-532
     @ ./~/font-awesome/css/font-awesome.css
     @ dll vendor

@MarkPieszak
Copy link
Member

@AbrarJahin
Copy link
Contributor Author

Yes, I am getting this error in a clean install in a new PC.

For some reason, I was not getting it in previous work repo.

I was also getting this on my new PC.

So, please ignore this PR.

Let me solve this and when it is solved, I will let u know.

Thanks for your help @MarkPieszak

@AbrarJahin AbrarJahin closed this Feb 8, 2017
@AbrarJahin AbrarJahin deleted the patch-1 branch February 8, 2017 02:17
@MarkPieszak
Copy link
Member

No problem! It seems something with webpack2 & font awesome just haven't had the time to research it specifically yet, why I left them in cdns for now. No worries we will figure it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants