Skip to content
This repository has been archived by the owner on Aug 30, 2019. It is now read-only.

Improvements for CollapseItem component #76

Merged
merged 2 commits into from May 11, 2017
Merged

Improvements for CollapseItem component #76

merged 2 commits into from May 11, 2017

Conversation

EduardTrutsyk
Copy link
Contributor

@EduardTrutsyk EduardTrutsyk commented May 4, 2017 •
edited

What does this PR do:

  • added othe props for collapseItem component
  • temporary adds the package dependency for create-react-class

@EduardTrutsyk EduardTrutsyk self-assigned this May 4, 2017
asci
asci reviewed May 4, 2017
View reviewed changes
components/collapse/collapseItem.js Outdated
};

CollapseItem.defaultProps = {
id: null,
isActive: false,
onClick: null,
labelProps: {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shared object?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b3c1829 on collapse-props into 92edfa8 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2b00949 on collapse-props into 92edfa8 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 91181b6 on collapse-props into 92edfa8 on master.

mAiNiNfEcTiOn
mAiNiNfEcTiOn reviewed May 5, 2017
View reviewed changes
components/collapse/collapseItem.js
/**
* Specify props for label
*/
labelProps: PropTypes.object,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little bit vague... no? Allowing everything to be passed 🙄 ... Oh well, your call.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2dde3f7 on collapse-props into 98a297b on master.

@mAiNiNfEcTiOn mAiNiNfEcTiOn merged commit 360d771 into master May 11, 2017
@mAiNiNfEcTiOn mAiNiNfEcTiOn deleted the collapse-props branch May 11, 2017 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@asci asci asci left review comments

@mAiNiNfEcTiOn mAiNiNfEcTiOn mAiNiNfEcTiOn left review comments

@AlexDudar AlexDudar AlexDudar approved these changes

@iwwwi iwwwi iwwwi approved these changes

@AlleeX AlleeX AlleeX approved these changes

@alinpiaa alinpiaa Awaiting requested review from alinpiaa

Assignees

@EduardTrutsyk EduardTrutsyk

Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@EduardTrutsyk @coveralls @asci @mAiNiNfEcTiOn @AlexDudar @iwwwi @AlleeX