Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature :: introduce s3 bucket with docker container #28

Closed
wants to merge 6 commits into from

Conversation

QuentinMadura
Copy link
Contributor

@QuentinMadura QuentinMadura commented Mar 13, 2020

This PR introduce:

@codecov
Copy link

codecov bot commented Mar 13, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #28   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         623    623           
=====================================
  Hits          623    623

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41106e0...7d4984a. Read the comment docs.

setup.cfg Outdated
@@ -19,12 +19,14 @@ packages = find:
install_requires =
certifi
chardet
docker
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these dependencies are only for tests. Please move them in the extras_require test section

Copy link
Contributor

@piotch piotch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@QuentinMadura could you do these changes in a branch starting from f/s3_match_true or directly in this branch, since we are going to use this for writing the tests

@PrettyWood
Copy link
Member

@piotch Actually I'm in favor of two distinct pull requests : one to add the docker pytest fixture + test the existing s3 code with a container and another one, which actually adds the match support by implementing listdir

@QuentinMadura QuentinMadura added the wip Work in progress label Mar 17, 2020
@piotch piotch closed this Mar 22, 2020
@piotch piotch deleted the f/s3_bucket_docker branch March 23, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants