-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature :: introduce s3 bucket with docker container #28
Conversation
f7c6477
to
b12bc3b
Compare
b12bc3b
to
ea18a32
Compare
ea18a32
to
eeea5f9
Compare
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 16 16
Lines 623 623
=====================================
Hits 623 623 Continue to review full report at Codecov.
|
setup.cfg
Outdated
@@ -19,12 +19,14 @@ packages = find: | |||
install_requires = | |||
certifi | |||
chardet | |||
docker |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these dependencies are only for tests. Please move them in the extras_require
test section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@QuentinMadura could you do these changes in a branch starting from f/s3_match_true
or directly in this branch, since we are going to use this for writing the tests
@piotch Actually I'm in favor of two distinct pull requests : one to add the docker pytest fixture + test the existing s3 code with a container and another one, which actually adds the match support by implementing listdir |
950e4a7
to
7d4984a
Compare
This PR introduce: