Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock 'Request' package to 2.81.0. #314

Merged
merged 1 commit into from Jan 19, 2018

Conversation

dmaltsiniotis
Copy link
Contributor

The 'Request' package maintainers have made a breaking change in version 2.82.0+ that no longer works on Node 0.10.x or 0.12.x. Since this package still specifies a supported engine of node 0.10.0, this PR locks the 'Request' package version to 2.81.0 forever.

While the "correct" solution here may be to not use node 0.x anymore since it's been deprecated, there are some packages and configurations that will break with change made in Request.

@dmaltsiniotis
Copy link
Contributor Author

See this issue for more information: request/request#2774

@hypesystem
Copy link
Collaborator

This makes sense to me.

Updating supported node version looks like a breaking change to me, so we should do that at some later point. Thoughts, @eladnava ?

@eladnava
Copy link
Collaborator

eladnava commented Jan 18, 2018

Hi @hypesystem and @dmaltsiniotis,
I would say, the best solution would be to lock down node-gcm to the last version of request that supports Node 0.x. There is no need to introduce any breaking change.

What do you think?

@dmaltsiniotis
Copy link
Contributor Author

dmaltsiniotis commented Jan 18, 2018

@eladnava @hypesystem I think we're all on the same page here. As it stands today, the node-gcm package does not work when attempting to use the latest version on node 0.x. This PR locks the version of Request down to the last one that worked on node 0.x, which was 2.81.0. I don't think this introduces any breaking changes.

@eladnava
Copy link
Collaborator

@dmaltsiniotis Sounds great.
@hypesystem Can we merge?

@hypesystem hypesystem merged commit 26887d3 into ToothlessGear:master Jan 19, 2018
@hypesystem
Copy link
Collaborator

@eladnava could I get you to publish on npm? I'm not at a PC for a while

@eladnava
Copy link
Collaborator

@hypesystem Definitely, just published 0.14.10. 😄

@hypesystem
Copy link
Collaborator

Great :-) Thanks for the contribution, @dmaltsiniotis !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants