fix : Adding both filter and sort for tjdb query is not working and it throws error #9794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -74,7 +74,7 @@ export class TooljetDbOperationsService implements QueryService { | |||
| !isEmpty(offset) && query.push(`offset=${offset}`); | |||
| } | |||
| const headers = { 'data-query-id': queryOptions.id, 'tj-workspace-id': queryOptions.organization_id }; | |||
| const url = `/api/tooljet-db/proxy/${tableId}` + `?${query}`; | |||
| const url = `/api/tooljet-db/proxy/${tableId}` + `?${query.join('&')}`; | |||
There was a problem hiding this comment.
Nit: can we only add this string ?... when query array has something? The URL which it hits looks unpolished otherwise without any query params
akshaysasidrn
previously approved these changes
May 21, 2024
|
Deployment: https://tooljet-pr-9794.onrender.com |
akshaysasidrn
approved these changes
May 22, 2024
Mekhla-Asopa
added
active-review-app
tested
and removed
suspend-review-app
needs testing
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : Adding both filter and sort for tjdb query is not working and it throws error
#9609