Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an EventEmitter to replay failed proxy connect HTTP requests #77

Merged
merged 2 commits into from Oct 7, 2019
Merged

Use an EventEmitter to replay failed proxy connect HTTP requests #77

merged 2 commits into from Oct 7, 2019

Commits on Oct 4, 2019

  1. Use an EventEmitter to replay failed proxy connect HTTP requests 

    This is a fix for https://hackerone.com/reports/541502.

Aborts the upstream proxy connection and instead uses a vanilla
`EventEmitter` instance to replay the "data" events on to. This way,
the node core `http` Client doesn't attempt to write the HTTP request
that is intended to go to the destination server to the proxy server.

Closes #76.
    @TooTallNate
    TooTallNate committed Oct 4, 2019
    Copy the full SHA
    bca6766 View commit details
    Browse the repository at this point in the history

  2. Adjust comment

    @TooTallNate
    TooTallNate committed Oct 4, 2019
    Copy the full SHA
    d9eb617 View commit details
    Browse the repository at this point in the history