Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compatibility with Node.js >= 10.0.0 #73

Closed
wants to merge 3 commits into from
Closed

Fix compatibility with Node.js >= 10.0.0 #73

wants to merge 3 commits into from

Commits on Jul 26, 2019

  1. Remove unreachable code 

    Node.js < 4.5.0 is no longer supported as per
TooTallNate@a2779222.
    @lpinca
    lpinca committed Jul 26, 2019
    Copy the full SHA
    84daab7 View commit details
    Browse the repository at this point in the history

  2. Fix compatibility with Node.js >= 10.0.0 

    Resume the socket after the `'socket'` event is emitted on the
`ClientRequest` object.

Refs: nodejs/node#24474 (comment)
Fixes: TooTallNate#58
    @lpinca
    lpinca committed Jul 26, 2019
    Copy the full SHA
    ec7c3ec View commit details
    Browse the repository at this point in the history

  3. Test on Node.js 10 and 12

    @lpinca
    lpinca committed Jul 26, 2019
    Copy the full SHA
    967f011 View commit details
    Browse the repository at this point in the history