Use quickjs-emscripten instead of vm2 to execute PAC file code
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `vm2` module has been deprecated and has critical security vulnerabilities. The suggested replacement module `isolated-vm` is not suitable for these packages, since it relies on a C++ binary. Instead, these packages will use the `quickjs-emscripten` module to execute the user code in an isolated QuickJS environment compiled to WASM. This should allow the highest level of sandboxing and will hopefully put an end to this cat and mouse game once and for all. Fixes #218.
🦋 Changeset detectedLatest commit: a8eb5fb The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
1 task
2 tasks
|
hey @TooTallNate first of all major kudos for the quick fix here ! just a question: do you think there's any chance backporting the fix to earlier major versions of edit: or perhaps only in |
|
@sfc-gh-dszmolka No, the fix will not be backported since this commit is a breaking change. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
vm2module has been deprecated and has critical security vulnerabilities. The suggested replacement moduleisolated-vmis not suitable for these packages, since it relies on a C++ binary. The reason for that is because the common use-case for these proxy agent modules is within CLI applications, which usually would not otherwise depend on a C++ module.Instead, these packages will use the
quickjs-emscriptenmodule to execute the user code in an isolated QuickJS environment compiled to WASM. This should allow the highest level of sandboxing and will hopefully put an end to this cat and mouse game once and for all.Fixes #218.