allow to specify options to the TLS upgrade

[joerg1985]

This change relates to the issue #194

[changeset-bot]

⚠️ No Changeset found

Latest commit: 230bf37

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
proxy-agents	✅ Ready (Inspect)	Visit Preview	Jun 1, 2023 3:39pm

[joerg1985]

@TooTallNate could you have a look at this?

[cptRaclette]

Would be great, if this feature could be added to the package.
Does its job like a charm!

[TooTallNate]

I would prefer to not introduce a 3rd parameter. This should be a new option on the opts object. Perhaps something like opts.tlsUpgradeOpts.

Additionally, I think this should be an option on the AgentBase class, since http-proxy-agent, https-proxy-agent and socks-proxy-agent all upgrade the socket to TLS using similar logic. We can introduce a helper function (AgentBase#upgradeSocketToTls() or similar) which all of those packages would invoke when appropriate.

Finally, this needs some tests.

[joerg1985]

I guess this should be done by someone with more experience in typescript.