Skip to content

Commit

Permalink
Adjust comment
Browse files Browse the repository at this point in the history
  • Loading branch information
TooTallNate committed Oct 4, 2019
1 parent bca6766 commit d9eb617
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions index.js
Expand Up @@ -159,9 +159,10 @@ HttpsProxyAgent.prototype.callback = function connect(req, opts, fn) {
// that the node core `http` can parse and handle the error status code
cleanup();

// The original socket is closed, and a "fake socket" EventEmitter is
// returned instead, so that the proxy doesn't get the HTTP request written
// to it (which may contain `Authorization` headers or other sensitive data.
// the original socket is closed, and a "fake socket" EventEmitter is
// returned instead, so that the proxy doesn't get the HTTP request
// written to it (which may contain `Authorization` headers or other
// sensitive data).
//
// See: https://hackerone.com/reports/541502
socket.destroy();
Expand Down

0 comments on commit d9eb617

Please sign in to comment.