Restrict use of global URL in certain packages (#246)

TooTallNate · Sep 8, 2023 · 523b74c · 523b74c · vercel · Sep 8, 2023
1 parent dd3b98f
commit 523b74c
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 0 deletions.
diff --git a/.changeset/fuzzy-walls-shake.md b/.changeset/fuzzy-walls-shake.md
@@ -0,0 +1,2 @@
+---
+---
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -13,4 +13,16 @@ module.exports = {
 		'plugin:@typescript-eslint/eslint-recommended',
 		'plugin:@typescript-eslint/recommended',
 	],
+	overrides: [
+		{
+			files: ['packages/{pac-proxy,proxy,socks-proxy}-agent/**/*'],
+			rules: {
+				'no-restricted-globals': [
+					'error',
+					// https://github.com/TooTallNate/proxy-agents/pull/242
+					{ name: 'URL', message: 'Use url.URL instead' },
+				],
+			},
+		},
+	],
 };
diff --git a/packages/proxy-agent/test/test.ts b/packages/proxy-agent/test/test.ts
@@ -1,6 +1,7 @@
 import * as fs from 'fs';
 import * as http from 'http';
 import * as https from 'https';
+import { URL } from 'url';
 import { once } from 'events';
 import assert from 'assert';
 import WebSocket, { WebSocketServer } from 'ws';

diff --git a/packages/socks-proxy-agent/test/test.ts b/packages/socks-proxy-agent/test/test.ts
@@ -3,6 +3,7 @@ import * as https from 'https';
 import * as http from 'http';
 import * as path from 'path';
 import * as fs from 'fs';
+import { URL } from 'url';
 import dns2 from 'dns2';
 // @ts-expect-error no types
 import socks from 'socksv5';