Skip to content

Commit

Permalink
Meh…
Browse files Browse the repository at this point in the history
  • Loading branch information
TooTallNate committed Oct 4, 2019
1 parent 3535951 commit 2590f76
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/test.js
Expand Up @@ -71,23 +71,23 @@ describe('HttpsProxyAgent', function () {

// shut down test HTTP server
after(function (done) {
server.once('close', function () { done(); });
server.close();
done();
});

after(function (done) {
proxy.once('close', function () { done(); });
proxy.close();
done();
});

after(function (done) {
sslServer.once('close', function () { done(); });
sslServer.close();
done();
});

after(function (done) {
sslProxy.once('close', function () { done(); });
sslProxy.close();
done();
});

describe('constructor', function () {
Expand Down

1 comment on commit 2590f76

@lpinca
Copy link
Contributor

@lpinca lpinca commented on 2590f76 Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TooTallNate any reason for this? Isn't better to wait the 'close' event to be sure that there are no connections left open? Would you accept a PR to revert this commit?

Please sign in to comment.