This repository has been archived by the owner on May 5, 2023. It is now read-only.
Update https-proxy-agent to fix a vulnerability
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The version bump should indeed be a separate commit. Can you remove that part please? |
|
Done! |
|
Kind ask to publish this as a non-breaking change 🙏 Unless you think it is? |
|
👋 @TooTallNate please let me know if there is anything else before this can be merged and released? Would lobe to get the two referenced Snyk issues fixed. |
This was referenced Oct 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See TooTallNate/proxy-agents#77
I took the liberty to bump the version to3.1.0, let me know if you want to do this on a separate commit.