Made loggers non-static to support deployment in containers #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reference see: http://slf4j.org/faq.html#declared_static https://cwiki.apache.org/confluence/display/COMMONS/Logging+StaticLog Signed-off-by: Victor Toni <victor.toni@gmail.com>
Signed-off-by: Victor Toni <victor.toni@gmail.com>
Signed-off-by: Victor Toni <victor.toni@gmail.com>
marci4
approved these changes
Jan 20, 2020
marci4
changed the title
|
@ViToni thx a lot for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slf4j Loggers were changed to be declared as non-static.
Description
The slf4j Loggers were declared as
private static final. This has been changed toprivate final.Related Issue
Fixes #969.
Motivation and Context
Usage of
private static finalloggers (or other classes in general) can be problematic it environments with shared classpaths and dynamic loading/unloading of JARs.For reference see:
http://slf4j.org/faq.html#declared_static
https://cwiki.apache.org/confluence/display/COMMONS/Logging+StaticLog
How Has This Been Tested?
No functional changes were introduced by this change.
Types of changes
Checklist:
(There were some failing tests before this change. The same ones are still failing.)