Add ability to customize ping messages with custom data #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilipRoman
approved these changes
Nov 21, 2019
|
@PhilipRoman thx for the review and @haruntuncay thx for the contribution |
marci4
requested changes
Nov 21, 2019
| * @return PingFrame to be sent. | ||
| */ | ||
| @Override | ||
| public PingFrame onPreparePing(WebSocket conn) { |
There was a problem hiding this comment.
Could you please include the argument?
marci4
approved these changes
Nov 21, 2019
marci4
changed the title
|
@PhilipRoman , @marci4 , Thank you both for the review and merge. |
marci4
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a method called
onPreparePingwhich provides a way for users customize their ping messages with custom data that they want to send.Related Issue
Fixes #941
Motivation and Context
Solves the problem where users were not able to customize ping messages. In this context, customizing means filling ping messages with custom payload data.
How Has This Been Tested?
Added a test file.
Types of changes
Checklist: