Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide way to start the client/server as daemons #1391

Merged
merged 1 commit into from Feb 4, 2024
Merged

Provide way to start the client/server as daemons #1391

merged 1 commit into from Feb 4, 2024

Conversation

PhilipRoman
Copy link
Collaborator

@PhilipRoman PhilipRoman commented Feb 3, 2024

This is a rewrite of #1201

I've rebased it on top of master, fixed style issues, removed unnecessary fields in subclasses and added a test case.

Fixes #888
Fixes #1390

@PhilipRoman PhilipRoman changed the title Provide way to start the client/server as daemons issue #888 Provide way to start the client/server as daemons Feb 3, 2024
@marci4 marci4 added this to the Release 1.5.6 milestone Feb 4, 2024
@marci4 marci4 merged commit 9f53da4 into master Feb 4, 2024
3 of 4 checks passed
@marci4 marci4 deleted the daemon branch February 4, 2024 13:59
@z1c0
Copy link

z1c0 commented Feb 5, 2024

That's fantastic news!
@marci4 is there already a planned release date for 1.5.6?

@PhilipRoman
Copy link
Collaborator Author

@z1c0 I just wanted to mention that if you want to get latest features from any Git commit you can always use something like JitPack: https://jitpack.io/#TooTallNate/Java-WebSocket
I used it in the past and it worked very well.
While we try to make new features available at a reasonable speed, this tool is very useful to avoid relying on the release schedule.

@marci4
Copy link
Collaborator

marci4 commented Feb 5, 2024

@z1c0 no plans, but I can make a release

@z1c0
Copy link

z1c0 commented Feb 5, 2024

@z1c0 no plans, but I can make a release

That would be very helpful as this would allow me to switch back to the original, unmodified version of this library.

(Adding additional repositories like JitPack unfortunately requires jumping over various organizational hurdles ... )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants