Test Flakiness is Fixed by adding the following changes #1293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flaky test failure is resolved with my fixes. I run the test many times, and every time the test passes.
Description
I only added the following code snippet at Line 898 of WebSocketClient.java
try {
Thread.sleep(100);
} catch (InterruptedException e) {
System.out.println("Exception");
}
Related Issue
#1291
Motivation and Context
After the code inspection, I found that the test was failing because some threads could not finish its task. On the other hand, another thread finishes countDownLatch() and starts assertion execution. This solution will wait which lets other threads finish their task before the assertion execution.
How Has This Been Tested?
With my solution, I run the test many times with the following command, and the test has never failed.
mvn test -Dtest=org.java_websocket.issues.Issue677Test#testIssue
Types of changes
Checklist:
Environment(please complete the following information):
I ran the test on an Ubuntu 20.04 LTS machine using OpenJDK 1.8.0_312.