Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a test failure (org.java_websocket.issues.Issue677Test#testIssue) #1292

Closed
wants to merge 2 commits into from
Closed

Conversation

java-codehunger
Copy link

The flaky test failure is resolved with my fixes. I run the test 10,000 times, and every time the test passes.

Description

I only added the following code snippet at Line 898 of WebSocketClient.java
try {
Thread.sleep(100);
} catch(InterruptedException e) {}

Related Issue

#1291

Motivation and Context

After the code inspection, I found that the test was failing because some threads could not finish its task. On the other hand, another thread finishes countDownLatch() and starts assertion execution. This solution will wait which lets other threads finish their task before the assertion execution.

How Has This Been Tested?

With my solution, I run the test 10,000 times with the following command, and the test is never failed.
mvn test -Dtest=org.java_websocket.issues.Issue677Test#testIssue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    I used mvn clean install -DskipTests -Dcheckstyle.skip
    Then I run the mvn test -Dtest=org.java_websocket.issues.Issue677Test#testIssue

other added 2 commits January 13, 2023 17:57
…by slowing down a particular thread's execution which was responsible to return isClosed() status
@java-codehunger
Copy link
Author

Need to fix checkstyle of this project. Hence, I submit another pull request, which will preserves the checkstyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant