test: fix timeout hiding runtime build error (vitejs#3185)

TobiasMelen · May 3, 2021 · fb46a33 · fb46a33
1 parent 8c942f3
commit fb46a33
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/packages/playground/ssr-react/__tests__/serve.js b/packages/playground/ssr-react/__tests__/serve.js
@@ -17,7 +17,7 @@ exports.serve = async function serve(root, isProd) {
     // client build
     await build({
       root,
-      logLevel: 'error',
+      logLevel: 'silent', // exceptions are logged by Jest
       build: {
         target: 'esnext',
         minify: false,
@@ -28,7 +28,7 @@ exports.serve = async function serve(root, isProd) {
     // server build
     await build({
       root,
-      logLevel: 'error',
+      logLevel: 'silent',
       build: {
         target: 'esnext',
         ssr: 'src/entry-server.jsx',

diff --git a/packages/playground/ssr-vue/__tests__/serve.js b/packages/playground/ssr-vue/__tests__/serve.js
@@ -17,7 +17,7 @@ exports.serve = async function serve(root, isProd) {
     // client build
     await build({
       root,
-      logLevel: 'error',
+      logLevel: 'silent', // exceptions are logged by Jest
       build: {
         target: 'esnext',
         minify: false,
@@ -28,7 +28,7 @@ exports.serve = async function serve(root, isProd) {
     // server build
     await build({
       root,
-      logLevel: 'error',
+      logLevel: 'silent',
       build: {
         target: 'esnext',
         ssr: 'src/entry-server.js',

diff --git a/packages/plugin-legacy/index.js b/packages/plugin-legacy/index.js
@@ -458,7 +458,7 @@ async function buildPolyfillChunk(
     // so that everything is resolved from here
     root: __dirname,
     configFile: false,
-    logLevel: 'error',
+    logLevel: 'silent', // exceptions are logged by Jest
     plugins: [polyfillsPlugin(imports)],
     build: {
       write: false,

diff --git a/scripts/jestPerTestSetup.ts b/scripts/jestPerTestSetup.ts
@@ -66,7 +66,7 @@ beforeAll(async () => {
 
       const options: UserConfig = {
         root: tempDir,
-        logLevel: 'error',
+        logLevel: 'silent',
         server: {
           watch: {
             // During tests we edit the files too fast and sometimes chokidar
@@ -100,6 +100,12 @@ beforeAll(async () => {
     // jest doesn't exit if our setup has error here
     // https://github.com/facebook/jest/issues/2713
     err = e
+
+    // Closing the page since an error in the setup, for example a runtime error 
+    // when building the playground should skip further tests.
+    // If the page remains open, a command like `await page.click(...)` produces
+    // a timeout with an exception that hides the real error in the console.
+    await page.close()
   }
 }, 30000)