Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotenvs have no "ENV " prefix on keys #2

Closed
wants to merge 1 commit into from
Closed

dotenvs have no "ENV " prefix on keys #2

wants to merge 1 commit into from

Conversation

lucasfcnunes
Copy link

@lucasfcnunes lucasfcnunes commented Feb 4, 2021 •
edited by Tinitto

dotenvs have

key=value
key2=value2
...

not

ENV key=value
ENV key2=value2
...

style...

This fixes #1

@lucasfcnunes
dotenvs have no "ENV " prefix on keys
0bc9b5c 
dotenvs have
```
key=value
key2=value2
...
```
style...
@lucasfcnunes lucasfcnunes mentioned this pull request Feb 5, 2021
Closed
@Tinitto
Copy link
Owner

Tinitto commented Mar 30, 2021

@lucasfcnunes , have you looked at the issue that occurs with :3000 when 'ENV' is removed as identified in issue #1 by @rbashish?
I think docker-compose changed something in the way env files are read in docker-compose 1.24.0 according to docker/compose#6951

From a quick check, removing 'ENV' makes the metabase endpoint fail to load.

@Tinitto
Copy link
Owner

Tinitto commented Mar 26, 2022

This might not be necessary after all.

@Tinitto Tinitto closed this Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

environment variable name 'ENV MB_DB_TYPE' may not contain whitespace
2 participants
@lucasfcnunes @Tinitto