Updated Kotlin and the libs for coroutines #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated scarlet-stream-adapter-coroutines to be compatible with 1.5.30 as well regarding use of asFlow and channels
greggiacovelli
force-pushed
the
update-kotlin
branch
2 times, most recently
from
5ee26f6
to
d1234ce
Compare
greggiacovelli
force-pushed
the
update-kotlin
branch
from
36de993
to
a59de17
Compare
…hannel Fixes Tinder#169 Fixes Tinder#163 Fixes Tinder#27
…havior of the past Relied on a subscription and a buffered observer, adding buffering
greggiacovelli
force-pushed
the
update-kotlin
branch
from
a59de17
to
55bb7fc
Compare
mhernand40
reviewed
Jan 6, 2022
demo/src/main/java/com/tinder/app/echo/domain/ChatMessageRepository.kt
Outdated
Show resolved
Hide resolved
...eam-adapter-coroutines/src/main/java/com/tinder/streamadapter/coroutines/ChannelForwarder.kt
Outdated
Show resolved
Hide resolved
...oroutines/src/test/java/com/tinder/scarlet/streamadapter/coroutines/FlowStreamAdapterTest.kt
Outdated
Show resolved
Hide resolved
| any<WebSocket.Event.OnMessageReceived>().containingBytes(bytesMessage2) | ||
| ) | ||
|
|
||
| assertThat(testTextChannel.take(2).toList()).containsExactly( |
There was a problem hiding this comment.
I do not fully follow the tests, but is this testTextChannel caching values that it may have already received?
There was a problem hiding this comment.
so the testTextChannel, (renamed to flow at this point) hasn't been read yet however since the connection is still open during this evaluation, we only want the first 2 values otherwise we would block indefinitely.
So yes in short the buffer acts like a cache
...oroutines/src/test/java/com/tinder/scarlet/streamadapter/coroutines/FlowStreamAdapterTest.kt
Outdated
Show resolved
Hide resolved
mhernand40
approved these changes
Jan 20, 2022
tinder-inakivillar
approved these changes
Jan 20, 2022
aaronweihe
approved these changes
Jan 30, 2022
|
thanks! @greggiacovelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds coroutine 1.6.0 support to scarlet
Publisher.openSubscription(): ReceiveChannelStream.Observerinterface in order to agree with Scarlet implementation, ideally this would be a cold flow that opens to connect however since the connection state is unknown it has to be hot. This is also in agreement with the previousopenSubscription()usageFlowStreamAdapterto allow for interfaces which return flow rather than channels,fun observeEvents(): Flow<Event>