Skip to content

Commit

Permalink
chore(cli): v2 python init templates have incorrect constructs version (
Browse files Browse the repository at this point in the history
aws#17333)

The init templates were modified as part of aws#17062. One change was for the 'app'
and 'sample-app' templates to use 'requirements.txt' instead of 'setup.py'. In
that conversion, a quirk of the `%constructsversion%` replacement was lost; that
replacement inserts the version comparison `>=` itself, so having it in the
requirements.txt results in a broken specifier.

This was caught in the forward-merge to v2, where there are additional tests
verfying the constructs versions.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
njlynch authored and TikiTDO committed Feb 21, 2022
1 parent 6bd9e25 commit 136035e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
aws-cdk-lib==%cdk-version%
aws-cdk.assertions-alpha==%cdk-version%
constructs>=%constructs-version%
constructs%constructs-version%
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
aws-cdk-lib==%cdk-version%
aws-cdk.assertions-alpha==%cdk-version%
constructs>=%constructs-version%
constructs%constructs-version%

0 comments on commit 136035e

Please sign in to comment.