Add (frontend-based) end-to-end testing starting point #2764

kschiffer · 2020-06-18T07:02:46Z

Summary

References #2605

This PR adds an initial state of (frontend-based) end-to-end testing to our codebase.

Changes

Adapt various mage targets to enable end-to-end test runs
- Database targets to snapshot, dump and restore the SQL database
- Improve target dependencies to enable better caching during CI
- Add endToEnd:* mage targets to setup and run end-to-end tests in various configurations
Add cypress
- As well as various related packages, tools and eslint-plugin
Add initial cypress tests and utilities
Add End to End Tests GitHub Action

Testing

Manual testing, running and verifying GitHub Actions on my private fork of TTS

Regressions

This might break affected dev/js/jsSdk mage targets.

Notes for Reviewers

Cypress

So as discussed in #2605, this uses Cypress as testing engine. I've included a couple of initial tests as well as some utility function that will help us logging in quickly, seeding the database (between runs) and grabbing DOM elements based on the test-id attribute.

To run the tests you need to do the following;

mage endToEnd:prepare only once initially, to build the stack and initialize the DB
Either:
- Run the stack with export TTN_LW_IS_DATABASE_URI="postgresql://root@localhost:26257/ttn_lorawan_test?sslmode=disable"
- Run the mage target mage endToEnd:runTestStack, which will do the same, but supress the output
If you run in development mode, you also need to run mage js:serve
mage endToEnd:run

Cypress offers an interactive mode, in which you can watch and debug the tests as you write them. You can run this via mage endToEnd:cypressOpen

The tests will run in a ttn-lorawan-test database so that there will be no clashes with the development database. Note that mage dev:DBErase will also delete this database.

@bafonins @pgalic96 @mjamescompton (and anyone who wants to write end-to-end tests for that matter), I recommend to read through the cypress docs since we will be making extensive use of these end-to-end tests once this is merged. The docs are very detailed and should give a good grasp of how to write cypress tests.

I also recommend taking note of the best practices and especially the section about "selecting elements" since we need to avoid selecting elements by arbitrary attributes that might not be persistent. Especially selecting by class is to be avoided, since the rendered classnames include arbitrary hashes. I've also included testing-library, which should help us selecting elements in a way that resembles actual use of the frontend, making the tests more robust and avoiding unnecessary refactors for unrelated code changes as much as possible.

I suggest that we keep track of our decisions of how to write cypress tests in DEVELOPMENT.md.

Happy to hear your thoughts, suggestions, etc. Let's try to get a robust setup going.

Github Action / CI

You can have a look at the actions here.

I've spent quite some time to get a good caching mechanism going, which can bring the runtime down to ~4mins in optimal cases. For usual JS changes, it should be around ~6min, which I think is reasonable enough. I've also disabled the caching for pushes to develop or master to ensure that there are no flakes going through from the caching mechanism.

The action is set up to run for pull requests as well as pushes to master or develop.

For failed runs, the Github Action will include a screenshot of the failed run as well as the video recordings of all tests. This data can be obtained from the "artifacts" section of the action.

@rvolosatovs there will be quite some conflicts with your recent mage refactors, I guess. I'll try to resolve these once your branches are merged.

Checklist

Scope: The referenced issue is addressed, there are no unrelated changes.
Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md. The target branch is set to master if the changes are fully compatible with existing API, database, configuration and CLI.
Documentation: Relevant documentation is added or updated.
Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

coveralls · 2020-06-18T07:15:34Z

Coverage increased (+0.02%) to 73.174% when pulling ebe9321 on feature/2605-end-to-end-testing-groundwork into 772db1a on master.

rvolosatovs

Only reviewed the mage parts.
Please wait for #2751 to be merged and then base your work on top of that - it's going to be done today I believe

.mage/dev.go

.mage/end_to_end.go

rvolosatovs · 2020-06-18T12:39:06Z

.mage/js.go

@@ -229,8 +250,13 @@ func (js Js) ServeMain() error {

 // Messages extracts the frontend messages via babel.
 func (js Js) Messages() error {
+	isCI := os.Getenv("CI") == "true"
+	cacheExists := pathExists("./.cache/messages")


This should be handled via target only, see #2751

See #2764 (comment)

rvolosatovs · 2020-06-18T12:39:16Z

.mage/js_sdk.go

@@ -58,8 +58,13 @@ func (k JsSDK) Deps() error {

 // Build builds the source files and output into 'dist'.
 func (k JsSDK) Build() error {
+	isCI := os.Getenv("CI") == "true"


This should not be necessary

See #2764 (comment)

.mage/js_sdk.go

.mage/utils.go

.mage/dev.go

bafonins

I would like to play with cypress for a bit to implement a bunch of tests so I can review this PR more meaningfully.

Could update DEVELOPMENT.md with instructions on how to setup and start e2e tests?

package.json

cypress/support/index.js

cypress/support/commands.js

pkg/webui/components/header/index.js

.github/workflows/end-to-end.yml

config/cypress.json

tools/mage/scripts/restore-db-dump.js

bafonins

Very good start. Some suggestions additionally to my other comments:
 

Lets use data-test-id as the test attribute.
1. For regular components we can use custom id like error-notification, login-form and so on. I dont think that BEM is appropriate to be used as test attributes.
2. For fields we can simply duplicate the field name in the test attribute. Initially, I was thinking about not using additional attributes for inputs and simply use the name attribute, however this approach makes selecting radio buttons more verbose as all buttons have the same name. For example, for payload formatters we can usedata-test-id=types-radio_{none|javascript|…}. For other inputs nothing else is required.
I would still prefer having documentation in place before merging this pr. Include:
1. Quick description that we use cypress.
2. We use describe and it to be consistent with already existing tests using jest and avoid using context, specify from mocha.
3. How to set e2e tests locally (dashboard access?)
4. Some generic guidelines you used when writing tests. We will define more strict guidelines later.

Also, @pgalic96 @mjamescompton please check this PR make sure that you understand whats happening here and run cypress locally.

bafonins · 2020-06-24T13:13:56Z

cypress/integration/login.spec.js

+
+    cy.location('pathname').should('include', '/oauth')
+
+    cy.findAllByText('incorrect password or user ID').should('exist')


I dont think we should check for the message as it is returned by the backend. All we care about here is that the path has no /console and the error notification is present on the screen.

Also, we should group related assertions together, remove new line between assertions

I dont think we should check for the message as it is returned by the backend. All we care about here is that the path has no /console and the error notification is present on the screen.

I disagree. The goal is to make the tests resemble the actual user experience as closely as possible. In this test case, a user would expect to be shown a notification that informs about the nature of the problem that lead to the submit not being successful. If we only check for the error notification, the test would also pass when there is a notification displaying irrelevant or no information. Generally speaking, the more we match realistic user expectations in our tests, the more confidence we can derive from them.

Also note that since this is an end-to-end test, it is legitimate to make assertions based on backend behavior.

Do you agree?

cypress/integration/logout.spec.js

cypress/integration/user-registration.spec.js

bafonins · 2020-06-24T13:37:30Z

cypress/integration/login.spec.js

+// limitations under the License.
+
+describe('Login and OAuth authorization', () => {
+  it('Displays an error on invalid login credentials', () => {


I would prefer describe and it descriptions to be consistent with other tests in webui

I'd like to do that in a separate PR which will also update the coding guidelines and streamlines all test names as a whole.

cypress/support/commands.js

bafonins · 2020-06-24T13:53:06Z

cypress/integration/login.spec.js

+      .should('have.value', 'admin')
+      .type('{enter}')
+
+    cy.grab('overview__welcome_text', { timeout: 10000 }).should('contain.text', 'Welcome')


Is there any way to avoid custom timeouts with cy.wait ?

I noticed that the loading time during login can vary quite a lot, especially when running in headless mode. The only way I see to account for that is increasing the timeout. Note that this does not mean that the command will wait for 10 seconds to look for the element. It means that will retry finding the elements for a maximum of 10 seconds (but usually find it sooner than that).

bafonins

misclicked 🤷‍♂️

johanstokking

@rvolosatovs please review tools/mage/** too

johanstokking · 2020-06-30T08:08:11Z

.github/workflows/end-to-end.yml

+      - name: Set up Go 1.14
+        uses: actions/setup-go@v1
+        with:
+          go-version: '1.14'


See other workflows (in develop)

johanstokking · 2020-06-30T08:09:04Z

.github/workflows/end-to-end.yml

+          restore-keys: |
+            ${{ runner.os }}-node-
+        if: env.should_cache
+      - name: Apply go modules cache


Lowercase go

johanstokking · 2020-06-30T08:09:19Z

.github/workflows/end-to-end.yml

+        if: env.should_cache
+      - name: Make Mage
+        run: make tools/bin/mage
+      - name: Set up Go 1.14


johanstokking · 2020-06-30T08:10:21Z

tools/mage/dev.go

+// SQLStart starts the SQL database of the development environment.
+func (Dev) SQLStart() error {
+	if mg.Verbose() {
+		fmt.Printf("Starting SQL databases\n")


nit; Println() without \n

johanstokking · 2020-06-30T08:10:27Z

tools/mage/dev.go

+// SQLMakeSnapshot stores the current cockroach data folder for later restores.
+func (Dev) SQLMakeSnapshot() error {
+	if mg.Verbose() {
+		fmt.Printf("Making DB snapshot")


Missing line ending here?

rvolosatovs · 2020-06-30T07:56:09Z

.github/workflows/end-to-end.yml

+on:
+  pull_request:
+    paths:
+      - '*.go'


Please make sure this is sorted disregarding the casing, just like all other workflows

rvolosatovs · 2020-06-30T07:56:43Z

.github/workflows/end-to-end.yml

+    name: Frontend based (cypress)
+    runs-on: ubuntu-18.04
+    env:
+      should_cache: true # Might be useful for debugging.


It might be useful, but we're not using it now, so remove

rvolosatovs · 2020-06-30T07:58:14Z

.github/workflows/end-to-end.yml

+        id: yarn-cache-dir-path
+        run: echo "::set-output name=dir::$(npx yarn cache dir)"
+        if: env.should_cache
+      - name: Apply yarn cache


Is there a reason not just copy-paste the same thing we have in all other workflows?

- name: Initialize Yarn module cache uses: actions/cache@v2 with: path: ${{ steps.yarn-cache-dir-path.outputs.dir }} key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} restore-keys: | ${{ runner.os }}-yarn-

rvolosatovs · 2020-06-30T07:59:23Z

.github/workflows/end-to-end.yml

+          restore-keys: |
+            ${{ runner.os }}-yarn-cache-
+        if: env.should_cache
+      - name: Apply npm cache


Since we're using yarn, npm cache should not be necessary.
In any case if you do this, you should do this in all other workflows as well that use JS caching.

rvolosatovs · 2020-06-30T07:59:44Z

.github/workflows/end-to-end.yml

+          restore-keys: |
+            ${{ runner.os }}-node-
+        if: env.should_cache
+      - name: Apply go modules cache


Again, don't reinvent the wheel - just copy-paste what we already have.

rvolosatovs · 2020-06-30T08:28:57Z

tools/mage/end-to-end.go

+	isCI := os.Getenv("CI") == "true"
+	dumpExists := pathExists(filepath.Join(".cache", "sqldump.sql"))
+	ok, err := target.Dir(
+		filepath.Join(".cache", "/sqldump.sql"),


Suggested change

filepath.Join(".cache", "/sqldump.sql"),

filepath.Join(".cache", "sqldump.sql"),

rvolosatovs · 2020-06-30T08:29:23Z

tools/mage/end-to-end.go

+
+func (EndToEnd) prepareDB() error {
+	isCI := os.Getenv("CI") == "true"
+	dumpExists := pathExists(filepath.Join(".cache", "sqldump.sql"))


redundant due to target.Dir call

#2764 (comment)

Please acknowledge.

rvolosatovs · 2020-06-30T08:29:37Z

tools/mage/end-to-end.go

+}
+
+func (EndToEnd) runCypress(command string, args ...string) error {
+	return runYarnCommand("cypress", append([]string{command, fmt.Sprintf("--config-file=%s", filepath.Join("config", "cypress.json")), "--config", fmt.Sprintf("baseUrl=%s", getTestURL())}, args...)...)


rvolosatovs · 2020-06-30T08:29:51Z

tools/mage/end-to-end.go

+	if nodeEnv == "development" {
+		port = "8080"
+	}
+	return "http://localhost:" + port


Use fmt.Sprintf

rvolosatovs · 2020-06-30T08:30:08Z

tools/mage/end-to-end.go

+
+var (
+	testDatabaseName = "ttn_lorawan_test"
+	databaseURI      = "postgresql://root@localhost:26257/" + testDatabaseName + "?sslmode=disable"


use fmt.Sprintf

bafonins

Please revise endToEnd mage targets, there are quite some inconsistencies most probably because of rebasing

bafonins · 2020-06-30T07:04:21Z

DEVELOPMENT.md

+To run end-to-end tests, observe the following mage target:
+
+```bash
+$ ./mage endToEnd:run


Suggested change

$ ./mage endToEnd:run

$ tools/bin/mage endToEnd:run

$ ./tools/bin/mage -v endToEnd:run Running target: EndToEnd:Run Running end-to-end tests Running dependency: go.thethings.network/lorawan-stack/tools/mage.EndToEnd.RunFrontend Running end-to-end frontend based tests Running dependency: go.thethings.network/lorawan-stack/tools/mage.EndToEnd.Cypress Running dependency: go.thethings.network/lorawan-stack/tools/mage.EndToEnd.WaitUntilReady Waiting for the stack to be ready... Running dependency: go.thethings.network/lorawan-stack/tools/mage.Js.Deps Error: Could not connect to server

Additionally, you need to run the stack manually, this is not part of the target.

From the OP:

To run the tests you need to do the following;

mage endToEnd:prepare only once initially, to build the stack and initialize the DB

Either:

Run the stack with export TTN_LW_IS_DATABASE_URI="postgresql://root@localhost:26257/ttn_lorawan_test?sslmode=disable"

Run the mage target mage endToEnd:runTestStack, which will do the same, but supress the output

If you run in development mode, you also need to run mage js:serve

mage endToEnd:run

True though that this info lacks in DEVELOPMENT.md

bafonins · 2020-06-30T07:04:29Z

DEVELOPMENT.md

+It is possible to run the tests in interactive mode, which is a helpful tool during development. To run the tests in interactive mode, you need to run the following command to prepare the environment:
+
+```bash
+$ ./mage endToEnd:prepare


Suggested change

$ ./mage endToEnd:prepare

$ tools/bin/mage endToEnd:prepare

bafonins · 2020-06-30T07:04:37Z

DEVELOPMENT.md

+This will build assets and set up the testing database. Then, you can run the stack in testing configuration via
+
+```bash
+$ ./mage endToEnd:startTestStack


Suggested change

$ ./mage endToEnd:startTestStack

$ tools/bin/mage endToEnd:startTestStack

bafonins · 2020-06-30T07:04:45Z

DEVELOPMENT.md

+Now, you can run the test in interactive mode via
+
+```bash
+$ ./mage endToEnd:runOpen


Suggested change

$ ./mage endToEnd:runOpen

$ tools/bin/mage endToEnd:runOpen

bafonins · 2020-06-30T07:20:55Z

DEVELOPMENT.md

+
+##### Guding Principle
+
+We follow the [guiding principle of Kent C. Dodds](https://twitter.com/kentcdodds/status/977018512689455106) ([@kentcdodds](https://twitter.com/kentcdodds)) for writing useful tests:


Do we really need a link to a twitter post?

bafonins · 2020-06-30T08:04:28Z

tools/mage/end-to-end.go

+// DBDump performs a database dump to the .cache folder.
+func (EndToEnd) DBDump() error {
+	if mg.Verbose() {
+		fmt.Printf("Execute database dump\n")


Suggested change

fmt.Printf("Execute database dump\n")

fmt.Println("Execute database dump")

bafonins · 2020-06-30T08:04:58Z

tools/mage/end-to-end.go

+func (EndToEnd) DBRestore() error {
+	mg.Deps(Js.Deps, Dev.DBStart)
+	if mg.Verbose() {
+		fmt.Printf("Restore database from dump")


Suggested change

fmt.Printf("Restore database from dump")

fmt.Println("Restore database from dump")

bafonins · 2020-06-30T08:06:53Z

tools/mage/end-to-end.go

+		return targetError(err)
+	}
+	if !ok || (isCI && dumpExists) {
+		mg.SerialDeps(EndToEnd.DBRestore)


Suggested change

mg.SerialDeps(EndToEnd.DBRestore)

mg.Deps(EndToEnd.DBRestore)

bafonins · 2020-06-30T08:41:55Z

tools/mage/end-to-end.go

+	if mg.Verbose() {
+		fmt.Println("Running end-to-end frontend based tests")
+	}
+	mg.Deps(EndToEnd.Cypress)


Why not moving Cypress here instead of using mg.Deps for chaining target calls?

#2764 (comment)

bafonins · 2020-06-30T08:52:48Z

cypress/integration/logout.spec.js

+    cy.login()
+    cy.visit('/console')
+    cy.get('header').within(() => {
+      cy.findByText('admin').click()


For me it reads like: there is the profile-dropdown entry in the header and it should display the users id

Suggested change

cy.findByText('admin').click()

cy.findByTestId('profile-dropdown')

.should('contain', 'admin')

.click()

this should possible as should returns the same subject it was given

kschiffer · 2020-06-30T11:03:57Z

Closing this since I don't think I will be able to bring this into an agreeable format within a reasonable amount of time. I can't spend more time on this currently and I think there are other people better suited to build this more quickly and thoroughly. If anyone wants to pick this up, feel free to use the branch as foundation/inspiration.

johanstokking · 2020-06-30T14:42:15Z

Not so fast. The scope of these tests, end-to-end, mean that there are a lot of concerns to be taken into account. It's perfectly fine to agree to disagree on things – I think all contributors commit to the importance of having end-to-end tests to catch regressions, and that those concerns outweigh concerns about implementation details.

rvolosatovs · 2020-06-30T15:00:01Z

I think it's very important to have end-to-end tests, however we should not make our own lives harder by introducing hacks and workarounds in our build process to allow for that - those come with a pretty high maintenance cost and later we end up with the same issue as was with the JS-related mage targets, where everything depends on everything, things break with no apparent reason and issues are very hard to debug/track and fix.
Can't we start with a simple script in github workflows to run an end-to-end test and then properly integrate this into mage tooling at a later point?

bafonins · 2020-07-14T11:58:11Z

Will reopen a new PR

johanstokking · 2020-07-24T07:54:44Z

@bafonins @kschiffer please delete this branch when no longer necessary

kschiffer added dependencies Pull requests that update a dependency file ui/web This is related to a web interface tooling Development tooling labels Jun 18, 2020

kschiffer added this to the June 2020 milestone Jun 18, 2020

kschiffer requested review from bafonins, htdvisser, johanstokking, pgalic96 and rvolosatovs as code owners June 18, 2020 07:02

kschiffer self-assigned this Jun 18, 2020

rvolosatovs suggested changes Jun 18, 2020

View reviewed changes

rvolosatovs reviewed Jun 18, 2020

View reviewed changes

.mage/dev.go Outdated Show resolved Hide resolved

bafonins reviewed Jun 19, 2020

View reviewed changes

package.json Show resolved Hide resolved

cypress/support/index.js Show resolved Hide resolved

cypress/support/commands.js Outdated Show resolved Hide resolved

pkg/webui/components/header/index.js Outdated Show resolved Hide resolved

kschiffer force-pushed the feature/2605-end-to-end-testing-groundwork branch from ebe9321 to 0622b5f Compare June 23, 2020 07:12

kschiffer requested review from adriansmares and KrishnaIyer as code owners June 23, 2020 07:12

kschiffer force-pushed the feature/2605-end-to-end-testing-groundwork branch from 0622b5f to 644f120 Compare June 23, 2020 14:48

kschiffer changed the base branch from master to develop June 24, 2020 00:28

kschiffer mentioned this pull request Jun 24, 2020

Recreate yarn.lock and fix JS fmt issues #2786

Merged

5 tasks

kschiffer force-pushed the feature/2605-end-to-end-testing-groundwork branch 3 times, most recently from 1840273 to da22f9f Compare June 24, 2020 07:48

htdvisser reviewed Jun 24, 2020

View reviewed changes

.github/workflows/end-to-end.yml Outdated Show resolved Hide resolved

config/cypress.json Outdated Show resolved Hide resolved

tools/mage/scripts/restore-db-dump.js Outdated Show resolved Hide resolved

kschiffer force-pushed the feature/2605-end-to-end-testing-groundwork branch 3 times, most recently from bcd9ee8 to 95cf206 Compare June 24, 2020 13:03

bafonins approved these changes Jun 24, 2020

View reviewed changes

bafonins self-requested a review June 24, 2020 14:05

bafonins suggested changes Jun 24, 2020

View reviewed changes

kschiffer added 9 commits June 30, 2020 12:12

dev: Add cypress

db9686b

console,oauth: Add test ids to components

f269817

dev: Add initial cypress tests

3e76b60

dev: Update yarn.lock

444e65f

dev: Refactor universal js utilities into global scope

a49a3d3

dev: Add end-to-end testing mage targets

a32a87c

dev: Add end-to-end test github action

fd25494

console,oauth: Improve field labels

15014ae

doc: Update development documentation about end-to-end tests

e0fbabc

kschiffer force-pushed the feature/2605-end-to-end-testing-groundwork branch from a62794d to e0fbabc Compare June 30, 2020 03:17

johanstokking reviewed Jun 30, 2020

View reviewed changes

rvolosatovs suggested changes Jun 30, 2020

View reviewed changes

bafonins suggested changes Jun 30, 2020

View reviewed changes

kschiffer closed this Jun 30, 2020

johanstokking reopened this Jun 30, 2020

johanstokking added the help wanted label Jun 30, 2020

bafonins self-assigned this Jun 30, 2020

kschiffer removed their assignment Jul 1, 2020

htdvisser modified the milestones: June 2020, July 2020 Jul 1, 2020

bafonins removed the help wanted label Jul 1, 2020

rvolosatovs mentioned this pull request Jul 13, 2020

Backend regression and backwards-compatibility testing #2895

Open

bafonins closed this Jul 14, 2020

bafonins mentioned this pull request Jul 19, 2020

Setup e2e tests for webui #2939

Merged

5 tasks

kschiffer deleted the feature/2605-end-to-end-testing-groundwork branch July 24, 2020 08:44


		cy.location('pathname').should('include', '/oauth')

		cy.findAllByText('incorrect password or user ID').should('exist')

	filepath.Join(".cache", "/sqldump.sql"),
	filepath.Join(".cache", "sqldump.sql"),

	$ ./mage endToEnd:startTestStack
	$ tools/bin/mage endToEnd:startTestStack


		##### Guding Principle

		We follow the [guiding principle of Kent C. Dodds](https://twitter.com/kentcdodds/status/977018512689455106) ([@kentcdodds](https://twitter.com/kentcdodds)) for writing useful tests:

	fmt.Printf("Execute database dump\n")
	fmt.Println("Execute database dump")

	fmt.Printf("Restore database from dump")
	fmt.Println("Restore database from dump")

	mg.SerialDeps(EndToEnd.DBRestore)
	mg.Deps(EndToEnd.DBRestore)

Add (frontend-based) end-to-end testing starting point #2764

Add (frontend-based) end-to-end testing starting point #2764

Conversation

kschiffer commented Jun 18, 2020 • edited

Summary

Changes

Testing

Regressions

Notes for Reviewers

Checklist

coveralls commented Jun 18, 2020

rvolosatovs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bafonins left a comment

Choose a reason for hiding this comment

bafonins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kschiffer Jun 25, 2020 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bafonins left a comment

Choose a reason for hiding this comment

johanstokking left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bafonins left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kschiffer commented Jun 30, 2020

johanstokking commented Jun 30, 2020

rvolosatovs commented Jun 30, 2020

bafonins commented Jul 14, 2020

johanstokking commented Jul 24, 2020

kschiffer commented Jun 18, 2020 •

edited

kschiffer Jun 25, 2020 •

edited