-
-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Nim Repository #230
[Add] Nim Repository #230
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
caniuse-lite must be updated. |
Thanks for the PR. Devicon (what we use for the icons) already seems to have the nim icon, but they haven't released a new version in a year. I've switched the url used for the icons to use the development branch of devicon, that way we get the nim icon. The issue with the 0 stars should not happen on the actual website, we use a api key there. And I will fix the other issues (caniuse,linting errors) outside of this PR. |
Nim now appears on the website, but the logo still does not appear correctly. It is still written Nim in plain text instead of showing the crown. |
Ah its only a issue in the dark mode because there is no |
I got it. I am in dark mode, and it does not have the dark mode version of the logo. |
Fix TheAlgorithms/Nim#6
What change does this pull request introduce?
Add Nim to the website.
https://www.nim-lang.org/
Screenshots
Checklist
main
.main
branch.I am not familiar with yarn.
I am waiting for fetch-algorithms.ts ending.
yarn lint
.There were 3 errors already present in preceding PRs. I do not know how to fix them and they are unrelated to my files.
yarn build
to check everything still builds successfully.