Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add] Nim Repository #230

Merged
merged 2 commits into from
Mar 17, 2023
Merged

[Add] Nim Repository #230

merged 2 commits into from
Mar 17, 2023

Conversation

dlesnoff
Copy link

@dlesnoff dlesnoff commented Mar 17, 2023

Fix TheAlgorithms/Nim#6

What change does this pull request introduce?
Add Nim to the website.
https://www.nim-lang.org/

Screenshots

Checklist

  • I worked on a branch other than main.
  • My branch is up-to-date with the Upstream main branch.

I am not familiar with yarn.
I am waiting for fetch-algorithms.ts ending.

  • I have fixed potential errors using yarn lint.
    There were 3 errors already present in preceding PRs. I do not know how to fix them and they are unrelated to my files.
  • I ran yarn build to check everything still builds successfully.

@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
website ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 17, 2023 at 3:39PM (UTC)

@dlesnoff
Copy link
Author

caniuse-lite must be updated.
Stars next to language repositories are equal to 0 (error: API limit exceeded).
Nim logo is incorrect (it is a little crown).

@maltejur
Copy link
Collaborator

maltejur commented Mar 17, 2023

Thanks for the PR.

Devicon (what we use for the icons) already seems to have the nim icon, but they haven't released a new version in a year. I've switched the url used for the icons to use the development branch of devicon, that way we get the nim icon.

The issue with the 0 stars should not happen on the actual website, we use a api key there. And I will fix the other issues (caniuse,linting errors) outside of this PR.

@dlesnoff
Copy link
Author

Nim now appears on the website, but the logo still does not appear correctly. It is still written Nim in plain text instead of showing the crown.

@maltejur
Copy link
Collaborator

Hm, works for me:

image

@maltejur
Copy link
Collaborator

Ah its only a issue in the dark mode because there is no plain nim devicon, you still have to use the original one. I've pushed the fix.

@dlesnoff
Copy link
Author

I got it. I am in dark mode, and it does not have the dark mode version of the logo.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add to the algorithms website
2 participants