Drop a test that has not been used since it was committed #3324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been dead code since its introduction and does not get executed by pytest due to starting with `text` rather than `test`. The underlying data for this test is also non-trivial to update and dependent on the specific Python version. Since this is already dead code and is non-trivial to update, removing this test more clearly reflects what happens with this dead code in tests and prevents potential confusion due to its presence.
This is unused and thus can be removed.
pradyunsg
force-pushed
the
drop-non-functional-test
branch
from
6fe4e25
to
f7e9360
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of changes
Checklist
Description
See commit messages. This PR will be easiest to review commit-by-commit.