Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robust handling of fileno #2678

Merged
merged 7 commits into from Nov 30, 2022
Merged

robust handling of fileno #2678

merged 7 commits into from Nov 30, 2022

Conversation

willmcgugan
Copy link
Collaborator

@willmcgugan willmcgugan commented Nov 30, 2022

More robust handling of fileno() which is often implemented badly in proxies and wrappers.

Should fix #2645

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Base: 98.39% // Head: 98.39% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (6925187) compared to base (379a38c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2678   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          63       64    +1     
  Lines        6796     6805    +9     
=======================================
+ Hits         6687     6696    +9     
  Misses        109      109           
Flag Coverage Δ
unittests 98.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/spinner.py 100.00% <ø> (ø)
rich/_fileno.py 100.00% <100.00%> (ø)
rich/console.py 98.01% <100.00%> (-0.01%) ⬇️
rich/pretty.py 98.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willmcgugan willmcgugan merged commit 9c0f164 into master Nov 30, 2022
@willmcgugan willmcgugan deleted the fileno branch November 30, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] rich.print("[bright_blue uu]" + message) crashes with NotImplementedError
3 participants