Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for locals max length #2657

Merged
merged 2 commits into from Dec 4, 2022
Merged

fix for locals max length #2657

merged 2 commits into from Dec 4, 2022

Conversation

willmcgugan
Copy link
Collaborator

Fixes #2649

@willmcgugan willmcgugan changed the title fix for locals maz length fix for locals max length Nov 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Base: 98.38% // Head: 98.38% // No change to project coverage 👍

Coverage data is based on head (af579fd) compared to base (c3a2450).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2657   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          64       64           
  Lines        6807     6807           
=======================================
  Hits         6697     6697           
  Misses        110      110           
Flag Coverage Δ
unittests 98.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/spinner.py 100.00% <ø> (ø)
rich/traceback.py 98.68% <ø> (ø)
rich/pretty.py 98.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@willmcgugan willmcgugan merged commit 2ab480d into master Dec 4, 2022
@willmcgugan willmcgugan deleted the locals-max-length branch December 4, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Traceback.from_exception ignores locals_max_length and locals_max_string arguments
2 participants