Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion error in Jupyter #2209

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Fix recursion error in Jupyter #2209

merged 2 commits into from
Apr 21, 2022

Conversation

willmcgugan
Copy link
Collaborator

Fixes #2047

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #2209 (939aac8) into master (7105781) will decrease coverage by 3.49%.
The diff coverage is 85.28%.

@@            Coverage Diff             @@
##           master    #2209      +/-   ##
==========================================
- Coverage   99.46%   95.97%   -3.50%     
==========================================
  Files          72       73       +1     
  Lines        7339     7606     +267     
==========================================
  Hits         7300     7300              
- Misses         39      306     +267     
Flag Coverage Δ
unittests 95.97% <85.28%> (-3.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/__main__.py 100.00% <ø> (ø)
rich/_windows_renderer.py 0.00% <0.00%> (-100.00%) ⬇️
rich/layout.py 100.00% <ø> (ø)
rich/markup.py 100.00% <ø> (ø)
rich/progress.py 92.77% <78.85%> (-5.66%) ⬇️
rich/progress_bar.py 99.00% <85.71%> (-1.00%) ⬇️
rich/console.py 97.22% <96.62%> (-1.92%) ⬇️
rich/__init__.py 100.00% <100.00%> (ø)
rich/_export_format.py 100.00% <100.00%> (ø)
rich/control.py 100.00% <100.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5f0b74...939aac8. Read the comment docs.

@willmcgugan willmcgugan merged commit 04687d4 into master Apr 21, 2022
@willmcgugan willmcgugan deleted the jupyter-print branch April 21, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] printing -\n- in rich.progress context manager will kill the jupyter.
2 participants