New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MofNCompleteColumn ProgressColumn type #1941
Add MofNCompleteColumn ProgressColumn type #1941
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
- Coverage 99.82% 99.81% -0.02%
==========================================
Files 71 71
Lines 6943 7042 +99
==========================================
+ Hits 6931 7029 +98
- Misses 12 13 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Would you mind also updating progress.rst, there is a list of column classes there.
Done. Also added blurb on Progress.get_default_columns (who knew there were docs?). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank's Paul! |
Type of changes
Checklist
Description
Added ProgressColumn
MofNCompleteColumn
to display rawcompleted/total
column (similar to DownloadColumn, but displays values as ints, does not convert to floats or add bit/bytes units).