Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flipped traceback border styles #1787

Merged
merged 1 commit into from Jan 6, 2022
Merged

Fix flipped traceback border styles #1787

merged 1 commit into from Jan 6, 2022

Conversation

AaronBeaudoin
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

The traceback border styles were backwards. I flipped them. That's it.

@willmcgugan
Copy link
Collaborator

I assume this fixes #1786 ?

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

Merging #1787 (e202448) into master (53b88a6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1787   +/-   ##
=======================================
  Coverage   99.82%   99.82%           
=======================================
  Files          71       71           
  Lines        6939     6939           
=======================================
  Hits         6927     6927           
  Misses         12       12           
Flag Coverage Δ
unittests 99.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/traceback.py 99.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72e002...e202448. Read the comment docs.

@AaronBeaudoin
Copy link
Contributor Author

This does not fix #1786. That's a different issue that I wasn't able to figure out.

@willmcgugan
Copy link
Collaborator

Thanks

@willmcgugan willmcgugan merged commit 6b49f36 into Textualize:master Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants